Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1245863003: Initialize CompositorDependencies in RenderWidget's constructor. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize CompositorDependencies in RenderWidget's constructor. Previously, this member was assigned ad-hoc during initialization of a RenderWidget. Since there are different initialization paths for different kinds of RenderWidgets, this led to some strange-looking code: for example, the initialization of a frame widget would double-assign CompositorDependencies. BUG=none TBR=mkwst@chromium.org Committed: https://crrev.com/35d31c110f4005d8d11377a5612f498116a5c6d1 Cr-Commit-Position: refs/heads/master@{#339795}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -116 lines) Patch
M components/test_runner/web_test_proxy.h View 1 chunk +2 lines, -2 lines 1 comment Download
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor_unittest.cc View 6 chunks +11 lines, -9 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 6 chunks +16 lines, -14 lines 0 comments Download
M content/renderer/render_widget.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_widget.cc View 5 chunks +12 lines, -14 lines 0 comments Download
M content/renderer/render_widget_fullscreen.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/render_widget_fullscreen.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/renderer/render_widget_unittest.cc View 5 chunks +50 lines, -48 lines 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
Some cleanup. Comes with bonus variadic templates.
5 years, 5 months ago (2015-07-21 21:46:46 UTC) #2
its_nick_at_chromium_org
lgtm https://codereview.chromium.org/1245863003/diff/1/components/test_runner/web_test_proxy.h File components/test_runner/web_test_proxy.h (right): https://codereview.chromium.org/1245863003/diff/1/components/test_runner/web_test_proxy.h#newcode305 components/test_runner/web_test_proxy.h:305: template <class Base, typename... Args> Wat. Actually wait ...
5 years, 5 months ago (2015-07-21 22:08:04 UTC) #4
ncarter (slow)
lgtm, from the right account this time
5 years, 5 months ago (2015-07-21 22:26:06 UTC) #5
dcheng
TBRing mkwst@ for components/test_runner changes.
5 years, 5 months ago (2015-07-21 23:01:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245863003/1
5 years, 5 months ago (2015-07-21 23:03:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 00:17:47 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 00:19:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35d31c110f4005d8d11377a5612f498116a5c6d1
Cr-Commit-Position: refs/heads/master@{#339795}

Powered by Google App Engine
This is Rietveld 408576698