Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1245793002: Roll src/third_party/skia a6ae14e:85693c1 (Closed)

Created:
5 years, 5 months ago by skia-deps-roller
Modified:
5 years, 5 months ago
Reviewers:
joshualitt
CC:
chromium-reviews, joshualitt, Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/skia a6ae14e:85693c1 Summary of changes available at: https://chromium.googlesource.com/skia/+log/a6ae14e..85693c1 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=joshualitt@google.com Commits in this roll: 85693c1 caryclark@google.com make stroketext textblob* texteffects tileimagefilter gm portable 942930d mtklein@chromium.org 565 support for SIMD xfermodes 1accc4c robertphillips@google.com Fix textureDomain/bleed prevention in msaa Committed: https://crrev.com/56b2dde5e64a5faea6561a900cf3f27bde3d7ad9 Cr-Commit-Position: refs/heads/master@{#339506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
skia-deps-roller
5 years, 5 months ago (2015-07-20 18:30:24 UTC) #1
skia-deps-roller
This roll was created by the Blink AutoRollBot. http://www.chromium.org/blink/blinkrollbot
5 years, 5 months ago (2015-07-20 18:30:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245793002/1
5 years, 5 months ago (2015-07-20 18:31:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 20:36:25 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/56b2dde5e64a5faea6561a900cf3f27bde3d7ad9 Cr-Commit-Position: refs/heads/master@{#339506}
5 years, 5 months ago (2015-07-20 20:37:25 UTC) #6
Mark Seaborn
This change appears to have caused a size increase of ~140k that got an unrelated ...
5 years, 5 months ago (2015-07-21 04:20:36 UTC) #7
Matt Giuca
I filed a bug about this regression, please keep it updated: http://crbug.com/512342.
5 years, 5 months ago (2015-07-21 07:42:29 UTC) #8
Matt Giuca
5 years, 5 months ago (2015-07-21 08:13:30 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1250573002/ by mgiuca@chromium.org.

The reason for reverting is: 942930d (included in this roll) introduced a 140 kB
sizes regression in libskia.so. Please investigate and reland if this regression
is necessary.

(Note: I have had to revert three Skia rolls.).

Powered by Google App Engine
This is Rietveld 408576698