Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1245713002: Fix missing "re" module import in GDB support script (Closed)

Created:
5 years, 5 months ago by aperez
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix missing "re" module import in GDB support script The gdb-v8-support.py script uses the "re" module to match regular expression, but it does not import it, resulting in an error when loading the script from GDB. This patch adds the missing import. BUG= Committed: https://crrev.com/abcab811b4a8d67a921aa517be1951ad79f8f99b Cr-Commit-Position: refs/heads/master@{#29770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gdb-v8-support.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aperez
5 years, 5 months ago (2015-07-20 16:50:51 UTC) #2
Michael Achenbach
lgtm
5 years, 5 months ago (2015-07-21 06:59:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245713002/1
5 years, 5 months ago (2015-07-21 09:01:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 09:28:38 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 09:28:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abcab811b4a8d67a921aa517be1951ad79f8f99b
Cr-Commit-Position: refs/heads/master@{#29770}

Powered by Google App Engine
This is Rietveld 408576698