media/audio/android/audio_manager_android.cc - Issue 12457043: Android implementation of WebAudio audio file decoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/android/audio_manager_android.cc

Issue 12457043: Android implementation of WebAudio audio file decoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/webkitplatformsupport_impl.h ('K') | « content/public/renderer/render_view.h ('k') | media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java » ('j') | media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/android/audio_manager_android.cc

diff --git a/media/audio/android/audio_manager_android.cc b/media/audio/android/audio_manager_android.cc

index e2899186894d38bcbcf0d5a1a21b2d51c4de8aaa..222f2e69433ce1c9b471f7bacaa1fb157f51d00b 100644

--- a/media/audio/android/audio_manager_android.cc

+++ b/media/audio/android/audio_manager_android.cc

@@ -85,8 +85,8 @@ AudioParameters AudioManagerAndroid::GetPreferredOutputStreamParameters(

const AudioParameters& input_params) {

// TODO(xians): figure out the right output sample rate and sample rate to

palmer 2013/04/02 18:01:08 I take it "output sample rate and sample rate" sho

Raymond Toy (Google) 2013/04/02 21:52:21 Yes. I will fix it.

// achieve the best audio performance for Android devices.

- static const int kDefaultSampleRate = 16000;

- static const int kDefaultBufferSize = 1024;

+ static const int kDefaultSampleRate = 44100;

palmer 2013/04/02 18:01:08 Does this mean the above TODO(xians) is resolved,

Raymond Toy (Google) 2013/04/02 21:52:21 Still not resolved yet. We need to ask the OS for

+ static const int kDefaultBufferSize = 2048;

ChannelLayout channel_layout = CHANNEL_LAYOUT_STEREO;

int sample_rate = kDefaultSampleRate;