chrome/renderer/extensions/resource_request_policy.cc - Issue 12457042: Non-web-accessible extension URLs should not load in non-extension processes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/resource_request_policy.cc

Issue 12457042: Non-web-accessible extension URLs should not load in non-extension processes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing issues found in code review. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_protocols.cc ('K') | « chrome/common/extensions/extension.h ('k') | chrome/test/data/chrome_extension_resource.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/resource_request_policy.cc

diff --git a/chrome/renderer/extensions/resource_request_policy.cc b/chrome/renderer/extensions/resource_request_policy.cc

index 756844ff8c19cf5e6374998f9ebdb4cad6ad106b..5843d8d5517c940dcfea0a2bcf7edffee8583344 100644

--- a/chrome/renderer/extensions/resource_request_policy.cc

+++ b/chrome/renderer/extensions/resource_request_policy.cc

@@ -24,6 +24,12 @@

namespace extensions {

+// This method does a security check whether chrome-extension:// URLs can be

+// requested by the renderer. Since this is in an untrusted process, the browser

+// has a similar check to enforce the policy, in case this process is exploited.

+// If you are changing this function, ensure equivalent checks are added to

+// extension_protocols.cc AllowExtensionResourceLoad.

Charlie Reis 2013/04/02 22:17:38 nit: extension_protocols.cc's

nasko 2013/04/03 15:51:50 Done.

// static

bool ResourceRequestPolicy::CanRequestResource(

const GURL& resource_url,

« chrome/browser/extensions/extension_protocols.cc ('K') | « chrome/common/extensions/extension.h ('k') | chrome/test/data/chrome_extension_resource.html » ('j') | no next file with comments »