Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: runtime/vm/flow_graph_compiler.h

Issue 12457034: Ensure that all goto instructions have deoptimization target. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler.h
diff --git a/runtime/vm/flow_graph_compiler.h b/runtime/vm/flow_graph_compiler.h
index f141fd18bc1e1d991133e9e4fe711fe6595153f2..bed363123edcedc589c0227f1e137a5758ee1e32 100644
--- a/runtime/vm/flow_graph_compiler.h
+++ b/runtime/vm/flow_graph_compiler.h
@@ -81,11 +81,6 @@ class CompilerDeoptInfo : public ZoneAllocated {
// No code needs to be generated.
virtual void GenerateCode(FlowGraphCompiler* compiler, intptr_t stub_ix) {}
- // Builds deopt-after continuation point.
- virtual void BuildReturnAddress(DeoptInfoBuilder* builder,
- const Function& function,
- intptr_t slot_ix);
-
intptr_t pc_offset() const { return pc_offset_; }
void set_pc_offset(intptr_t offset) { pc_offset_ = offset; }
@@ -119,11 +114,6 @@ class CompilerDeoptInfoWithStub : public CompilerDeoptInfo {
// Implementation is in architecture specific file.
virtual void GenerateCode(FlowGraphCompiler* compiler, intptr_t stub_ix);
- // Builds deopt-before continuation point.
- virtual void BuildReturnAddress(DeoptInfoBuilder* builder,
- const Function& function,
- intptr_t slot_ix);
-
private:
Label entry_label_;
@@ -264,7 +254,6 @@ class FlowGraphCompiler : public ValueObject {
LocationSummary* locs);
void GenerateInstanceOf(intptr_t token_pos,
- intptr_t deopt_id,
Florian Schneider 2013/04/12 09:23:55 Why remove deopt_id here?
Vyacheslav Egorov (Google) 2013/04/12 10:57:06 Reinstated.
const AbstractType& type,
bool negate_result,
LocationSummary* locs);

Powered by Google App Engine
This is Rietveld 408576698