Issue 12457031: cc: Changed total_pixels_rasterized to be a return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12457031: cc: Changed total_pixels_rasterized to be a return value (Closed)

Created:
7 years, 9 months ago by vmpstr

Modified:
7 years, 9 months ago

Reviewers:
enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Changed total_pixels_rasterized to be a return value It's a bit awkward calling Raster and passing an output parameter that is never used. Instead, it makes sense to make it a return value, and simply not capture it if its not required. BUG=223590 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190569

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -17 lines)			Patch
M	cc/layers/picture_layer_impl_unittest.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	cc/resources/picture_pile_impl.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	cc/resources/picture_pile_impl.cc	View	6 chunks	+9 lines, -8 lines	0 comments	Download
M	cc/resources/tile_manager.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/12457031/1

7 years, 9 months ago (2013-03-25 18:12:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/12457031/1

7 years, 9 months ago (2013-03-26 06:50:54 UTC) #4

Message was sent while issue was closed.

Change committed as 190569

Expand Messages | Collapse Messages