Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7008)

Unified Diff: build/isolate.gypi

Issue 12457024: test_isolation_outdir must be considered an opaque string, it could be an url. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: with condition Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/isolate.gypi
diff --git a/build/isolate.gypi b/build/isolate.gypi
index d7523fdfb389028747bca14cc61ceb2d82ca407b..2b80c42ac60ebf9e7bba84158b9c14c1c90d2362 100644
--- a/build/isolate.gypi
+++ b/build/isolate.gypi
@@ -55,21 +55,30 @@
'outputs': [
'<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).isolated',
],
- 'action': [
- 'python',
- '<(DEPTH)/tools/swarm_client/isolate.py',
- '<(test_isolation_mode)',
- '--outdir', '<(test_isolation_outdir)',
- '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
- '--variable', 'OS', '<(OS)',
- '--variable', 'chromeos', '<(chromeos)',
- '--result', '<@(_outputs)',
- '--isolate', '<(RULE_INPUT_PATH)',
- ],
'conditions': [
- ["test_isolation_outdir!=''", {
+ ["test_isolation_outdir==''", {
M-A Ruel 2013/03/13 19:20:01 changed to be more explicit.
+ 'action': [
+ 'python',
+ '<(DEPTH)/tools/swarm_client/isolate.py',
+ '<(test_isolation_mode)',
+ '--outdir', '<(PRODUCT_DIR)',
+ '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
+ '--variable', 'OS', '<(OS)',
+ '--variable', 'chromeos', '<(chromeos)',
+ '--result', '<@(_outputs)',
+ '--isolate', '<(RULE_INPUT_PATH)',
+ ],
+ }, {
'action': [
- '--outdir', '<(PRODUCT_DIR)/<(test_isolation_outdir)',
+ 'python',
+ '<(DEPTH)/tools/swarm_client/isolate.py',
+ '<(test_isolation_mode)',
+ '--outdir', '<(test_isolation_outdir)',
+ '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
+ '--variable', 'OS', '<(OS)',
+ '--variable', 'chromeos', '<(chromeos)',
+ '--result', '<@(_outputs)',
+ '--isolate', '<(RULE_INPUT_PATH)',
],
}],
['test_isolation_fail_on_missing == 0', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698