Issue 12457022: Unpin the Clang version used by the OS X bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12457022: Unpin the Clang version used by the OS X bots. (Closed)

Created:
7 years, 9 months ago by Alexander Potapenko

Modified:
7 years, 8 months ago

Reviewers:
Nico, (unused - use chromium)

CC:
chromium-reviews, eugenis+clang_chromium.org, dmikurube+clang_chromium.org, glider+clang_chromium.org, glotov+watch_chromium.org, ukai+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Unpin the Clang version used by the OS X bots. This CL only changes the Clang version to the one used by other bots. Code cleanup will be done separately. BUG=170629 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195771

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/clang/scripts/update.sh	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

7 years, 8 months ago (2013-04-23 15:57:14 UTC) #4

I had to disable two tests because of crbug.com/234591. It looks like
a real issue with ASan, but will probably affect only loaded plugins
in some special cases, so it should be fine for now.
The bots are cycling green now.

On Tue, Apr 23, 2013 at 7:49 PM,  <thakis@chromium.org> wrote:
> lgtm!
>
> How do things look? Do you think this will stick?
>
> https://codereview.chromium.org/12457022/

-- 
Alexander Potapenko
Software Engineer
Google Moscow

Expand Messages | Collapse Messages