Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12457021: Revert 187427 "PPAPI: Remove threading options; it's always on" (Closed)

Created:
7 years, 9 months ago by karen
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert 187427 "PPAPI: Remove threading options; it's always on" > PPAPI: Remove threading options; it's always on > > This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere. > > BUG=159240, 92909 > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186925 > Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=186939 due to build errors > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187340 > > Review URL: https://chromiumcodereview.appspot.com/12378050 TBR=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187716

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -259 lines) Patch
M build/common.gypi View 3 chunks +9 lines, -0 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_ipc_untrusted.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_proxy_untrusted.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared_untrusted.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/proxy/device_enumeration_resource_helper_unittest.cc View 10 chunks +37 lines, -60 lines 0 comments Download
M ppapi/proxy/file_chooser_resource_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/flash_resource_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D ppapi/proxy/locking_resource_releaser.h View 1 chunk +0 lines, -41 lines 0 comments Download
M ppapi/proxy/plugin_globals.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_globals.cc View 2 chunks +24 lines, -18 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_resource_tracker_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M ppapi/proxy/ppb_var_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ppapi/proxy/printing_resource_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ppapi/proxy/websocket_resource_unittest.cc View 6 chunks +14 lines, -15 lines 0 comments Download
M ppapi/shared_impl/resource_tracker.h View 4 chunks +14 lines, -16 lines 0 comments Download
M ppapi/shared_impl/resource_tracker.cc View 8 chunks +10 lines, -16 lines 0 comments Download
M ppapi/shared_impl/test_globals.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/test_globals.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/shared_impl/var_tracker.h View 4 chunks +10 lines, -19 lines 0 comments Download
M ppapi/shared_impl/var_tracker.cc View 12 chunks +27 lines, -21 lines 0 comments Download
M ppapi/tests/test_case.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/plugins/plugin_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/plugin_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/host_globals.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/host_var_tracker.cc View 6 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karen
7 years, 9 months ago (2013-03-13 00:33:11 UTC) #1
karen
7 years, 9 months ago (2013-03-13 00:33:27 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r187716.

Powered by Google App Engine
This is Rietveld 408576698