Added "None available" title and grey out the media menu when there is no device.

Added "None available" title and grey out the media menu when there is no device.

When capture device list is empty, we show a "None available" title to clearly tell the users there is no device, instead of having empty menu.
This will also fix the problem when the height of the empty menu is not the same as the other menu with item.

BUG=178383
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190028

[no longer working on chromium, 2013-03-07 15:32:30]

Peter, could you please review this fix? And I also find 500 for
kMaxContentsWidth is a bit insufficient, could we enlarge it to 800 or 600?

Thanks,
SX

[Peter Kasting, 2013-03-07 17:00:16]

Instead of showing an empty list, can we dim the label and have the menu contain
the entry "<No devices available>" (which maps to no device)?  This eliminates
the need for the explicit fix here, because all menus will be non-empty, and it
seems clearer to me.

Can you provide some screenshots of 500 versus other widths for the max width? 
This max is across all bubbles, so it warrants caution when changing it.  In
particular 800 may be too large as Chrome windows may only be 800 px wide total
in some cases.

[no longer working on chromium, 2013-03-08 13:45:30]

On 2013/03/07 17:00:16, Peter Kasting wrote:
> Instead of showing an empty list, can we dim the label and have the menu
contain
> the entry "<No devices available>" (which maps to no device)?  This eliminates
> the need for the explicit fix here, because all menus will be non-empty, and
it
> seems clearer to me.
> 

Adding text and grey out the button sounds ok to me.
How about text like "No camera detected" and "No microphone detected"?
or simply "None"

I have to point out that gmail uses blank menu.
please see http://imgur.com/MGpDiLm

> Can you provide some screenshots of 500 versus other widths for the max width?

> This max is across all bubbles, so it warrants caution when changing it.  In
> particular 800 may be too large as Chrome windows may only be 800 px wide
total
> in some cases.

hmm, I am also hesitated on enlarge the pixel number more than 600. My question
is triggered by how it looks like in aura, please see http://imgur.com/Tt74veb.
You can see that the radio button is truncated even when the hostname is still
in a reasonably length.

Let me know how you think, I am open to add "no device" text to the menu or keep
the menu blank.

[Peter Kasting, 2013-03-11 21:03:32]

On 2013/03/08 13:45:30, xians1 wrote:
> On 2013/03/07 17:00:16, Peter Kasting wrote:
> > Instead of showing an empty list, can we dim the label and have the menu
> contain
> > the entry "<No devices available>" (which maps to no device)?  This
eliminates
> > the need for the explicit fix here, because all menus will be non-empty, and
> it
> > seems clearer to me.
> 
> Adding text and grey out the button sounds ok to me.
> How about text like "No camera detected" and "No microphone detected"?
> or simply "None"

All of these are fine with me.  Get a tech writer and/or UI designer to make the
final call perhaps.

> I have to point out that gmail uses blank menu.
> please see http://imgur.com/MGpDiLm

Yeah... I think saying something in the button is nicer.

> > Can you provide some screenshots of 500 versus other widths for the max
width?
> 
> > This max is across all bubbles, so it warrants caution when changing it.  In
> > particular 800 may be too large as Chrome windows may only be 800 px wide
> total
> > in some cases.
> 
> hmm, I am also hesitated on enlarge the pixel number more than 600. My
question
> is triggered by how it looks like in aura, please see
http://imgur.com/Tt74veb.
> You can see that the radio button is truncated even when the hostname is still
> in a reasonably length.

Enlarging doesn't fix this bug.  What about when
longsubdomain.longdomainname.com wants to use your camera and mic?  It seems
like the radio label needs to line-wrap.  I'd go for that solution instead of
enlarging the menu more (the menu is already pretty wide).

[no longer working on chromium, 2013-03-21 12:11:07]

Hi Peter,

The UI designers decided to go for "None available", and I have already changed
to the code and description to address the feature. Could you please take
another look?

FYI, I will address the Mac on another CL.

SX

[no longer working on chromium, 2013-03-22 12:16:17]

Add sky in case Peter is not available.

Could either of you please review the CL?

BR,
SX

[Peter Kasting, 2013-03-22 19:43:13]

LGTM

https://codereview.chromium.org/12457016/diff/9001/chrome/browser/ui/views/co...
File chrome/browser/ui/views/content_setting_bubble_contents.cc (right):

https://codereview.chromium.org/12457016/diff/9001/chrome/browser/ui/views/co...
chrome/browser/ui/views/content_setting_bubble_contents.cc:342: // Make sure the
width is more than kMinMediaMenuButtonWidth, and the
Nit: "more than" -> "at least", ", and the" -> ".  The"

[no longer working on chromium, 2013-03-23 16:03:08]

https://codereview.chromium.org/12457016/diff/9001/chrome/browser/ui/views/co...
File chrome/browser/ui/views/content_setting_bubble_contents.cc (right):

https://codereview.chromium.org/12457016/diff/9001/chrome/browser/ui/views/co...
chrome/browser/ui/views/content_setting_bubble_contents.cc:342: // Make sure the
width is more than kMinMediaMenuButtonWidth, and the
On 2013/03/22 19:43:13, Peter Kasting wrote:
> Nit: "more than" -> "at least", ", and the" -> ".  The"

Done.

[commit-bot: I haz the power, 2013-03-23 16:18:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xians@chromium.org/12457016/17001

[no longer working on chromium, 2013-03-23 16:35:50]

Committed patchset #3 manually as r190028 (presubmit successful).