Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1245653002: [turbofan] Move workaround with TDZ of 'this' variable. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move workaround with TDZ of 'this' variable. Note that this just narrows the existing workaround for any 'this' in derived constructors (having a temporal dead zone) so that we can still recognize static cases correctly (i.e. when 'this' is provably outside or inside the temporal dead zone). R=rossberg@chromium.org Committed: https://crrev.com/d67e07f3971b3fe6ecff612b5b73e9191b0e32c4 Cr-Commit-Position: refs/heads/master@{#29762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
Ugly workaround is being ugly (but optimized). :)
5 years, 5 months ago (2015-07-20 15:04:56 UTC) #1
rossberg
lgtm
5 years, 5 months ago (2015-07-20 15:56:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245653002/1
5 years, 5 months ago (2015-07-20 15:57:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 16:02:11 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 16:02:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d67e07f3971b3fe6ecff612b5b73e9191b0e32c4
Cr-Commit-Position: refs/heads/master@{#29762}

Powered by Google App Engine
This is Rietveld 408576698