Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1245643002: Generate platform specific fontmgr gm. (Closed)

Created:
5 years, 5 months ago by caryclark
Modified:
5 years, 5 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Generate platform specific fontmgr gm. The gm output on different font platforms is so different that comparing images in Gold has little value. Separate the images by appending platform information to the gm name to group somewhat similar images together. Note that this does not attempt to make sure that all images generated by Gold are nearly pixel identical; it only reduces the number of nonsensical comparisons. R=bungeman@google.com Committed: https://skia.googlesource.com/skia/+/6531c3619f08cc83aad34883c5f00f6a358c9fad

Patch Set 1 #

Patch Set 2 : use the --key string array to annotate gm test names #

Total comments: 2

Patch Set 3 : add key placeholder to enable SampleApp and VisualBench to link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M gm/fontmgr.cpp View 1 3 chunks +8 lines, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/VisualBench/VisualBench.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/sk_tool_utils.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/sk_tool_utils.cpp View 1 2 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
caryclark
5 years, 5 months ago (2015-07-20 14:48:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245643002/1
5 years, 5 months ago (2015-07-20 14:48:19 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-20 14:55:40 UTC) #5
caryclark
5 years, 5 months ago (2015-07-20 20:09:11 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245643002/20001
5 years, 5 months ago (2015-07-20 20:09:18 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/4516)
5 years, 5 months ago (2015-07-20 20:10:31 UTC) #10
bungeman-skia
https://codereview.chromium.org/1245643002/diff/20001/tools/sk_tool_utils.cpp File tools/sk_tool_utils.cpp (right): https://codereview.chromium.org/1245643002/diff/20001/tools/sk_tool_utils.cpp#newcode18 tools/sk_tool_utils.cpp:18: extern bool internal_tool_utils_win_gdi(); Not using this anymore?
5 years, 5 months ago (2015-07-20 20:15:11 UTC) #11
caryclark
https://codereview.chromium.org/1245643002/diff/20001/tools/sk_tool_utils.cpp File tools/sk_tool_utils.cpp (right): https://codereview.chromium.org/1245643002/diff/20001/tools/sk_tool_utils.cpp#newcode18 tools/sk_tool_utils.cpp:18: extern bool internal_tool_utils_win_gdi(); On 2015/07/20 20:15:11, bungeman1 wrote: > ...
5 years, 5 months ago (2015-07-20 20:28:12 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245643002/40001
5 years, 5 months ago (2015-07-20 20:28:30 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-20 20:36:05 UTC) #16
bungeman-skia
lgtm
5 years, 5 months ago (2015-07-20 20:37:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245643002/40001
5 years, 5 months ago (2015-07-20 20:38:21 UTC) #19
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 20:38:58 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6531c3619f08cc83aad34883c5f00f6a358c9fad

Powered by Google App Engine
This is Rietveld 408576698