Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1245623003: [Autofill] Copy attributes for the select elements as well. (Closed)

Created:
5 years, 5 months ago by Mathieu
Modified:
5 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Copy attributes for the select elements as well. Not setting is_autofilled on select fields results in wrong metrics in FormStructure::LogQualityMetrics. BUG=512127 Committed: https://crrev.com/8f7fa53a1605e205875391360b9070bb66428ac1 Cr-Commit-Position: refs/heads/master@{#339675}

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : updated heuristic tests #

Messages

Total messages: 14 (5 generated)
Mathieu
Hi Evan, Please have a look, thanks.
5 years, 5 months ago (2015-07-20 19:05:40 UTC) #2
Evan Stade
lgtm
5 years, 5 months ago (2015-07-21 00:32:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245623003/20001
5 years, 5 months ago (2015-07-21 03:06:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/30074)
5 years, 5 months ago (2015-07-21 04:05:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245623003/40001
5 years, 5 months ago (2015-07-21 15:43:52 UTC) #10
Mathieu
As a result of attributes being copied, some heuristics test outputs had to be changed. ...
5 years, 5 months ago (2015-07-21 15:44:39 UTC) #11
Evan Stade
still lgtm
5 years, 5 months ago (2015-07-21 15:50:45 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-21 17:16:42 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 17:17:51 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f7fa53a1605e205875391360b9070bb66428ac1
Cr-Commit-Position: refs/heads/master@{#339675}

Powered by Google App Engine
This is Rietveld 408576698