Issue 124553006: Nukes Link::OnPaint, it's not needed and causes double focus border

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 124553006: Nukes Link::OnPaint, it's not needed and causes double focus border (Closed)

Created:
6 years, 11 months ago by sky

Modified:
6 years, 11 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Nukes Link::OnPaint, it's not needed and causes double focus border Label::OnPaint also draws a focus border, so Link doesn't need to do it. BUG=330675 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243351

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	ui/views/controls/link.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	ui/views/controls/link.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/124553006/1

6 years, 11 months ago (2014-01-06 23:46:20 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242299

6 years, 11 months ago (2014-01-07 11:33:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/124553006/1

6 years, 11 months ago (2014-01-07 17:16:44 UTC) #5

Message was sent while issue was closed.

Change committed as 243351

Expand Messages | Collapse Messages