Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1245523002: [turbofan]: Fix tail calls edge cases and add tests (Closed)

Created:
5 years, 5 months ago by danno
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@1220823004
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan]: Fix tail calls edge cases and add tests Committed: https://crrev.com/d1a6dfaf4d1be19764faa986fd23b9657fbe7f94 Cr-Commit-Position: refs/heads/master@{#29791}

Patch Set 1 #

Patch Set 2 : Add unit tests #

Patch Set 3 : Fix formatting #

Patch Set 4 : Tweaks #

Patch Set 5 : More precise test #

Patch Set 6 : Cleanup tests #

Total comments: 1

Patch Set 7 : Fix 64 bit #

Patch Set 8 : Review feedback #

Patch Set 9 : Fix ASAN #

Patch Set 10 : Fix ASAN #

Patch Set 11 : Fix compilation #

Patch Set 12 : Fix ASAN again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -4 lines) Patch
M src/compiler/linkage.cc View 1 2 3 4 5 6 7 3 chunks +23 lines, -4 lines 0 comments Download
A test/unittests/compiler/linkage-tail-call-unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +320 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
danno
PTAL
5 years, 5 months ago (2015-07-20 15:21:58 UTC) #2
danno
5 years, 5 months ago (2015-07-21 11:44:40 UTC) #4
titzer
https://codereview.chromium.org/1245523002/diff/100001/test/unittests/compiler/linkage-tail-call-unittest.cc File test/unittests/compiler/linkage-tail-call-unittest.cc (right): https://codereview.chromium.org/1245523002/diff/100001/test/unittests/compiler/linkage-tail-call-unittest.cc#newcode53 test/unittests/compiler/linkage-tail-call-unittest.cc:53: LocationSignature::Builder locations1(zone(), 1, 0); You don't have to use ...
5 years, 5 months ago (2015-07-21 11:48:52 UTC) #5
danno
On 2015/07/21 at 11:48:52, titzer wrote: > https://codereview.chromium.org/1245523002/diff/100001/test/unittests/compiler/linkage-tail-call-unittest.cc > File test/unittests/compiler/linkage-tail-call-unittest.cc (right): > > https://codereview.chromium.org/1245523002/diff/100001/test/unittests/compiler/linkage-tail-call-unittest.cc#newcode53 ...
5 years, 5 months ago (2015-07-21 14:19:05 UTC) #6
titzer
lgtm
5 years, 5 months ago (2015-07-22 15:22:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245523002/220001
5 years, 5 months ago (2015-07-22 15:27:39 UTC) #9
commit-bot: I haz the power
Committed patchset #12 (id:220001)
5 years, 5 months ago (2015-07-22 18:27:21 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 18:27:41 UTC) #11
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/d1a6dfaf4d1be19764faa986fd23b9657fbe7f94
Cr-Commit-Position: refs/heads/master@{#29791}

Powered by Google App Engine
This is Rietveld 408576698