Issue 12455009: Unify wgl context creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12455009: Unify wgl context creation. (Closed)

Created:
7 years, 9 months ago by bsalomon

Modified:
7 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Unify wgl context creation. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=7990

Patch Set 3 : #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -165 lines)			Patch
M	include/utils/SkWGL.h	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/gpu/gl/win/SkNativeGLContext_win.cpp	View		2 chunks	+2 lines, -54 lines	0 comments	Download
M	src/utils/win/SkWGL_win.cpp	View	1 2	1 chunk	+105 lines, -0 lines	2 comments	Download
M	src/views/win/SkOSWindow_win.cpp	View	1	2 chunks	+3 lines, -111 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

LGTM + 1 comment suggestion https://codereview.chromium.org/12455009/diff/5002/src/utils/win/SkWGL_win.cpp File src/utils/win/SkWGL_win.cpp (right): https://codereview.chromium.org/12455009/diff/5002/src/utils/win/SkWGL_win.cpp#newcode329 src/utils/win/SkWGL_win.cpp:329: if (0 == format) ...

7 years, 9 months ago (2013-03-05 18:46:22 UTC) #2

bsalomon

https://codereview.chromium.org/12455009/diff/5002/src/utils/win/SkWGL_win.cpp File src/utils/win/SkWGL_win.cpp (right): https://codereview.chromium.org/12455009/diff/5002/src/utils/win/SkWGL_win.cpp#newcode329 src/utils/win/SkWGL_win.cpp:329: if (0 == format) { On 2013/03/05 18:46:22, robertphillips ...

7 years, 9 months ago (2013-03-05 18:52:21 UTC) #3

bsalomon

7 years, 9 months ago (2013-03-05 19:13:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r7990 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12455009: Unify wgl context creation. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages