src/runtime.cc - Issue 12455002: ES6 symbols: filter symbols form for-in loops and Object.keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 12455002: ES6 symbols: filter symbols form for-in loops and Object.keys (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index bd18302e1a3a5539ea18ffb92ee28f31294c3157..bdfea164744344bac81e45b7ed0b076c948089bf 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -4873,7 +4873,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_LocalKeys) {

Handle<FixedArray> copy = isolate->factory()->NewFixedArray(length);

for (int i = 0; i < length; i++) {

Object* entry = contents->get(i);

- if (entry->IsName()) {

+ if (entry->IsString()) {

copy->set(i, entry);

} else {

ASSERT(entry->IsNumber());

« no previous file with comments | « src/proxy.js ('k') | src/v8natives.js » ('j') | no next file with comments »