Issue 12454004: Revert 186187 - crashing on Win XP browser_tests with "Access is denied".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12454004: Revert 186187 - crashing on Win XP browser_tests with "Access is denied". (Closed)

Created:
7 years, 9 months ago by flackr

Modified:
7 years, 9 months ago

Reviewers:
girard

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 186187 - crashing on Win XP browser_tests with "Access is denied". > Fix touch scaling for high dpi windows. > > Touch events in windows are always expressed in screen coordinates, even if > the target app is not dpi-aware. This patch determines the dpi scale used > by the OS, and re-scales touch events accordingly. > > In some cases the touch events are sent to the wrong window. This is detected > and corrected. > > BUG=175542 > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185474 > > Review URL: https://chromiumcodereview.appspot.com/12317157 TBR=girard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186196

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -74 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_win.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	ui/base/win/dpi.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/base/win/dpi.cc	View	4 chunks	+1 line, -47 lines	0 comments	Download
M	ui/base/win/hwnd_subclass.cc	View	2 chunks	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

girard

7 years, 9 months ago (2013-03-05 20:33:20 UTC) #3

Message was sent while issue was closed.

On 2013/03/05 17:53:25, flackr wrote:
> Committed patchset #1 manually as r186196.

LGTM - thanks, Rob

Expand Messages | Collapse Messages