Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1245333002: [Andorid] Migrate to ClipDrawable progress bar. (Closed)

Created:
5 years, 5 months ago by Kibeom Kim (inactive)
Modified:
5 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Andorid] Migrate to ClipDrawable progress bar. Using ClipDrawable progress bar helps future changes for http://crbug.com/461148 as we only need pass to color parameters. Also it has minor performance benefit. Note: second landing attempt as the previous one made Chrome shell tests flaky. https://codereview.chromium.org/1170843002/ TBR=tedchoc@chromium.org BUG=466140, 455891, 461148 Committed: https://crrev.com/bbc76fefb3fb606df4464917997b26d9c27aed59 Cr-Commit-Position: refs/heads/master@{#339803}

Patch Set 1 #

Patch Set 2 : Fix flaky Chrome shell tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -477 lines) Patch
D chrome/android/java/res/drawable/progress_bar.xml View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/android/java/res/drawable/progress_bar_white.xml View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/android/java/res/layout/custom_tabs_toolbar.xml View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/android/java/res/layout/toolbar.xml View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/res/values/attrs.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarControlContainer.java View 4 chunks +32 lines, -74 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarDataProvider.java View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java View 6 chunks +30 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 7 chunks +65 lines, -76 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 3 chunks +10 lines, -14 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/widget/ClipDrawableProgressBar.java View 1 chunk +248 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java View 2 chunks +58 lines, -141 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/QueryInOmniboxTest.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java View 2 chunks +59 lines, -37 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java View 1 4 chunks +15 lines, -18 lines 0 comments Download
D chrome/android/shell/res/drawable/shell_progress_bar.xml View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/android/shell/res/layout/chrome_shell_activity.xml View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceAdapter.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Kibeom Kim (inactive)
ptal. Patch set 1 is what I landed before, and patch set 2 has the ...
5 years, 5 months ago (2015-07-21 20:49:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245333002/20001
5 years, 5 months ago (2015-07-21 20:54:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245333002/20001
5 years, 5 months ago (2015-07-21 23:33:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 00:51:21 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 00:52:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bbc76fefb3fb606df4464917997b26d9c27aed59
Cr-Commit-Position: refs/heads/master@{#339803}

Powered by Google App Engine
This is Rietveld 408576698