Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm - Issue 1245323002: Pass scroll bar placement as an enum instead of std::string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm

Issue 1245323002: Pass scroll bar placement as an enum instead of std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix the headers to pass depchecks Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/scroll/ScrollbarThemeMacCommon.h ('K') | « Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h ('k') | Source/web/mac/WebScrollbarTheme.mm » ('j') | public/platform/mac/MacScrollTypes.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm

diff --git a/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm b/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm

index 1aaec1b8fd19ac1132eb0371d72279bca310af7d..b42ceb5bb6f601c595366cdabb9a5aeda4d822e5 100644

--- a/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm

+++ b/Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm

@@ -58,16 +58,9 @@ static int cOuterButtonOverlap = 2;

static ScrollbarButtonsPlacement gButtonPlacement = ScrollbarButtonsDoubleEnd;

-void ScrollbarThemeMacNonOverlayAPI::updateButtonPlacement(const std::string& buttonPlacement)

+void ScrollbarThemeMacNonOverlayAPI::updateButtonPlacement(ScrollbarButtonsPlacement buttonPlacement)

{

- if (buttonPlacement == "Single")

- gButtonPlacement = ScrollbarButtonsSingle;

- else if (buttonPlacement == "DoubleMin")

- gButtonPlacement = ScrollbarButtonsDoubleStart;

- else if (buttonPlacement == "DoubleBoth")

- gButtonPlacement = ScrollbarButtonsDoubleBoth;

- else

- gButtonPlacement = ScrollbarButtonsDoubleEnd;

+ gButtonPlacement = buttonPlacement;

}

// Override ScrollbarThemeMacCommon::paint() to add support for the following: