Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h - Issue 1245323002: Pass scroll bar placement as an enum instead of std::string

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h

Issue 1245323002: Pass scroll bar placement as an enum instead of std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updates per code review Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/platform/scroll/ScrollbarThemeMacCommon.mm ('k') | Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 30 matching lines...) Expand all Loading...
41 bool usesOverlayScrollbars() const override { return false; }	41 bool usesOverlayScrollbars() const override { return false; }

42 ScrollbarButtonsPlacement buttonsPlacement() const override;	42 ScrollbarButtonsPlacement buttonsPlacement() const override;

43	43

44 bool paint(ScrollbarThemeClient, GraphicsContext, const IntRect& damageRec t) override;	44 bool paint(ScrollbarThemeClient, GraphicsContext, const IntRect& damageRec t) override;

45	45

46 protected:	46 protected:

47 IntRect trackRect(ScrollbarThemeClient*, bool painting = false) override;	47 IntRect trackRect(ScrollbarThemeClient*, bool painting = false) override;

48 IntRect backButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;	48 IntRect backButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool painting = false) override;

49 IntRect forwardButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool paintin g = false) override;	49 IntRect forwardButtonRect(ScrollbarThemeClient*, ScrollbarPart, bool paintin g = false) override;

50	50

51 void updateButtonPlacement(const std::string& buttonPlacement) override;	51 void updateButtonPlacement(ScrollbarButtonsPlacement) override;

52	52

53 bool hasButtons(ScrollbarThemeClient*) override;	53 bool hasButtons(ScrollbarThemeClient*) override;

54 bool hasThumb(ScrollbarThemeClient*) override;	54 bool hasThumb(ScrollbarThemeClient*) override;

55	55

56 int minimumThumbLength(ScrollbarThemeClient*) override;	56 int minimumThumbLength(ScrollbarThemeClient*) override;

57 };	57 };

58	58

59 }	59 }

60	60

61 #endif	61 #endif

OLD	NEW