Chromium Code Reviews
Help | Chromium Project | Sign in
(19)

Issue 12453021: Revert 190596 "Extract input_method_whitelist.{h|cc} from c/b/ch..." (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by ygorshenin1
Modified:
1 year ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Revert 190596 "Extract input_method_whitelist.{h|cc} from c/b/ch..."

> Extract input_method_whitelist.{h|cc} from c/b/chromeos.
>
> This is part of extraction work for input method from chrome/browser/chromeos.
>
> BUG=164375
> TEST=None
> TBR=sky
>
> Review URL: https://chromiumcodereview.appspot.com/12438012

TBR=nona@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -503 lines) Lint Patch
A + trunk/src/chrome/browser/chromeos/input_method/gen_input_methods.py View 0 chunks +-1 lines, --1 lines 0 comments 0 errors Download
M trunk/src/chrome/browser/chromeos/input_method/ibus_controller_impl.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
A + trunk/src/chrome/browser/chromeos/input_method/input_method.gyp View 0 chunks +-1 lines, --1 lines 0 comments 0 errors Download
M trunk/src/chrome/browser/chromeos/input_method/input_method_manager_impl.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M trunk/src/chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
A + trunk/src/chrome/browser/chromeos/input_method/input_method_whitelist.h View 0 chunks +-1 lines, --1 lines 0 comments 0 errors Download
A + trunk/src/chrome/browser/chromeos/input_method/input_method_whitelist.cc View 0 chunks +-1 lines, --1 lines 0 comments 0 errors Download
A + trunk/src/chrome/browser/chromeos/input_method/input_method_whitelist_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments 0 errors Download
A + trunk/src/chrome/browser/chromeos/input_method/input_methods.txt View 0 chunks +-1 lines, --1 lines 0 comments 0 errors Download
M trunk/src/chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M trunk/src/chrome/browser/chromeos/input_method/xkeyboard_unittest.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M trunk/src/chrome/chrome_browser_chromeos.gypi View 3 chunks +3 lines, -1 line 0 comments 0 errors Download
M trunk/src/chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
MM trunk/src/chromeos/chromeos.gyp View 3 chunks +0 lines, -4 lines 0 comments 0 errors Download
D trunk/src/chromeos/ime/gen_input_methods.py View 1 chunk +0 lines, -123 lines 0 comments 0 errors Download
D trunk/src/chromeos/ime/input_method.gyp View 1 chunk +0 lines, -40 lines 0 comments 0 errors Download
D trunk/src/chromeos/ime/input_method_whitelist.h View 1 chunk +0 lines, -46 lines 0 comments 0 errors Download
D trunk/src/chromeos/ime/input_method_whitelist.cc View 1 chunk +0 lines, -45 lines 0 comments 0 errors Download
D trunk/src/chromeos/ime/input_method_whitelist_unittest.cc View 1 chunk +0 lines, -32 lines 0 comments 0 errors Download
D trunk/src/chromeos/ime/input_methods.txt View 1 chunk +0 lines, -212 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
ygorshenin1
1 year ago #1
ygorshenin1
1 year ago #2
Message was sent while issue was closed.
Committed patchset #1 manually as r190643.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6