Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1245273006: sel_main_chrome: Remove now-unneeded call to NaClSecureCommandChannel() (Closed)

Created:
5 years, 5 months ago by Mark Seaborn
Modified:
5 years, 3 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

sel_main_chrome: Remove now-unneeded call to NaClSecureCommandChannel() Chromium no longer connects to the trusted SRPC command channel (since https://codereview.chromium.org/1153293003 was committed), so we can remove the call that spawns the thread that listens on this channel. BUG=https://code.google.com/p/chromium/issues/detail?id=496287 TEST=Manually ran some of Chromium's browser_tests Committed: https://chromium.googlesource.com/native_client/src/native_client/+/495bd47427a144f90c2340890c265bb39eccca12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M src/trusted/service_runtime/sel_main_chrome.c View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
5 years, 3 months ago (2015-08-27 00:15:54 UTC) #2
Derek Schuff
LGTM, although I don't really have familiarity with this code. IIUC, this doesn't specifically have ...
5 years, 3 months ago (2015-08-27 06:26:19 UTC) #3
Mark Seaborn
On 26 August 2015 at 23:26, <dschuff@chromium.org> wrote: > LGTM, although I don't really have ...
5 years, 3 months ago (2015-08-27 20:53:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245273006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1245273006/1
5 years, 3 months ago (2015-08-27 20:55:08 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 22:56:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/495bd4742...

Powered by Google App Engine
This is Rietveld 408576698