Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: extensions/renderer/resources/media_router_bindings.js

Issue 1245213002: [MediaRouter] Implement send binary message from PSDImpl to MRPManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: override in media_router_android Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/media_router_bindings.js
diff --git a/extensions/renderer/resources/media_router_bindings.js b/extensions/renderer/resources/media_router_bindings.js
index eb0d35539f2c3ff87f0e6dedceabe2576bd595e5..5985c46c79f64937d556978a00b3e63ab15deec8 100644
--- a/extensions/renderer/resources/media_router_bindings.js
+++ b/extensions/renderer/resources/media_router_bindings.js
@@ -316,6 +316,11 @@ define('media_router_bindings', [
this.sendRouteMessage = null;
/**
+ * @type {function(string, Array.<uint8>): Promise}
+ */
+ this.sendRouteBinaryMessage = null;
+
+ /**
* @type {function(Array.<string>): Promise.<Array.<RouteMessage>>}
*/
this.listenForRouteMessages = null;
@@ -368,6 +373,7 @@ define('media_router_bindings', [
'stopObservingMediaRoutes',
'startObservingMediaRoutes',
'sendRouteMessage',
+ 'sendRouteBinaryMessage',
'listenForRouteMessages',
'closeRoute',
'joinRoute',
@@ -479,6 +485,23 @@ define('media_router_bindings', [
};
/**
+ * Sends a binary message to the route designated by |routeId|.
+ * @param {!string} routeId
+ * @param {!Array.<uint8>} data
Kevin M 2015/07/22 18:31:50 "uint8" isn't a valid JS type?
USE s.singapati at gmail.com 2015/07/23 19:52:53 Done. Changed to Uint8Array.
+ * @return {!Promise.<boolean>} Resolved with true if the data was sent,
+ * or false on failure.
+ */
+ MediaRouteProvider.prototype.sendRouteBinaryMessage = function(
+ routeId, data) {
+ return this.handlers_.sendRouteBinaryMessage(routeId, data)
+ .then(function() {
Kevin M 2015/07/22 18:34:04 Please refer to the fix in CL #1249083003 and make
USE s.singapati at gmail.com 2015/07/23 19:52:53 Done.
+ return true;
+ }, function() {
+ return false;
+ });
+ };
+
+ /**
* Listen for next batch of messages from one of the routeIds.
* @param {!Array.<string>} routeIds
* @return {!Promise.<Array.<RouteMessage>>} Resolved with a list of messages,
« chrome/browser/media/router/test_helper.h ('K') | « chrome/browser/media/router/test_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698