[MediaRouter] Implement send binary message from PSDImpl to MRPManager

chrome/browser/media/router/media_router_mojo_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/router/media_router_mojo_impl.h"
 
 #include "base/bind.h"
 #include "base/guid.h"
 #include "base/logging.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 226 matching lines @@
 void MediaRouterMojoImpl::SendRouteMessage(
     const MediaRoute::Id& route_id,
     const std::string& message,
     const SendRouteMessageCallback& callback) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   RunOrDefer(base::Bind(&MediaRouterMojoImpl::DoSendSessionMessage,
                         base::Unretained(this), route_id, message, callback));
 }
 
+void MediaRouterMojoImpl::SendRouteBinaryMessage(
+    const MediaRoute::Id& route_id,
+    scoped_ptr<std::vector<uint8>> data,
+    const SendRouteMessageCallback& callback) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+
+  RunOrDefer(base::Bind(&MediaRouterMojoImpl::DoSendSessionBinaryMessage,
+                        base::Unretained(this), route_id, data.get(),

[haibinlu, 2015/07/28 18:57:19]

data.Pass()

[USE s.singapati at gmail.com, 2015/07/28 19:11:46]

Then DoSendSessionBinaryMessage() has to take scoped_ptr<std::vector<uint8>>.
And base::Bind() did not allow to take scoped_ptr<>. I will check it once again.
 

[Kevin M, 2015/07/28 20:03:36]

Use base::Passed(data.Pass()).

If you just pass the bare pointer with .get(), you're passing a bad reference,
because |data| goes out of scope and is deleted as soon as
SendRouteBinaryMessage finishes.

[USE s.singapati at gmail.com, 2015/07/29 11:22:01]

Done.

+                        callback));
+}
+
 void MediaRouterMojoImpl::ListenForRouteMessages(
     const std::vector<MediaRoute::Id>& route_ids,
     const PresentationSessionMessageCallback& message_cb) {
   DCHECK(thread_checker_.CalledOnValidThread());
   RunOrDefer(base::Bind(&MediaRouterMojoImpl::DoListenForRouteMessages,
                         base::Unretained(this), route_ids, message_cb));
 }
 
 void MediaRouterMojoImpl::ClearIssue(const Issue::Id& issue_id) {
   DCHECK(thread_checker_.CalledOnValidThread());
@@ skipping 114 matching lines @@
 }
 
 void MediaRouterMojoImpl::DoSendSessionMessage(
     const MediaRoute::Id& route_id,
     const std::string& message,
     const SendRouteMessageCallback& callback) {
   DVLOG_WITH_INSTANCE(1) << "SendRouteMessage " << route_id;
   media_route_provider_->SendRouteMessage(route_id, message, callback);
 }
 
+void MediaRouterMojoImpl::DoSendSessionBinaryMessage(
+    const MediaRoute::Id& route_id,
+    std::vector<uint8>* data,
+    const SendRouteMessageCallback& callback) {
+  DVLOG_WITH_INSTANCE(1) << "SendRouteBinaryMessage " << route_id;
+  mojo::Array<uint8> mojo_array;
+  mojo_array.Swap(data);
+  media_route_provider_->SendRouteBinaryMessage(route_id, mojo_array.Pass(),
+                                                callback);
+}
+
 void MediaRouterMojoImpl::DoListenForRouteMessages(
     const std::vector<MediaRoute::Id>& route_ids,
     const PresentationSessionMessageCallback& message_cb) {
   DVLOG_WITH_INSTANCE(1) << "ListenForRouteMessages";
   media_route_provider_->ListenForRouteMessages(
       mojo::Array<mojo::String>::From(route_ids),
       base::Bind(&MediaRouterMojoImpl::OnRouteMessageReceived,
                  base::Unretained(this), message_cb));
 }
 
@@ skipping 80 matching lines @@
     return;
   }
 
   for (const auto& next_request : pending_requests_)
     next_request.Run();
 
   pending_requests_.clear();
 }
 
 }  // namespace media_router