Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 12452012: Use code_range()->exists() to determine the size of the first code page when code range is used. (Closed)

Created:
7 years, 9 months ago by haitao.feng
Modified:
7 years, 9 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Use code_range()->exists() to determine the size of the first code page when code range is used. Committed: http://code.google.com/p/v8/source/detail?r=14071

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/spaces.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haitao.feng
Instead of kPointerSize comparison.
7 years, 9 months ago (2013-03-15 22:10:06 UTC) #1
danno
https://codereview.chromium.org/12452012/diff/1/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/12452012/diff/1/src/spaces.cc#newcode1034 src/spaces.cc:1034: // On x64 we allocate code pages in a ...
7 years, 9 months ago (2013-03-18 13:09:03 UTC) #2
haitao.feng
Thanks for the review. This change is for X32. The kPointerSize is 4 for X32 ...
7 years, 9 months ago (2013-03-19 01:41:59 UTC) #3
danno
lgtm
7 years, 9 months ago (2013-03-25 17:21:19 UTC) #4
danno
7 years, 9 months ago (2013-03-25 17:28:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14071 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698