pkg/unittest: locking down TestCase

pkg/unittest/lib/unittest.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A library for writing dart unit tests.
  *
- * To import this library, install the 
- * [unittest package](http://pub.dartlang.org/packages/unittest) via the pub 
+ * To import this library, install the
+ * [unittest package](http://pub.dartlang.org/packages/unittest) via the pub
  * package manager. See the [Getting Started](http://pub.dartlang.org/doc)
  * guide for more details.
  *
  * ##Concepts##
  *
  *  * __Tests__: Tests are specified via the top-level function [test], they can be
  *    organized together using [group].
  *  * __Checks__: Test expectations can be specified via [expect]
  *  * __Matchers__: [expect] assertions are written declaratively using the
  *    [Matcher] class.
@@ skipping 225 matching lines @@
  */
 Map testState = {};
 
 /**
  * Creates a new test case with the given description and body. The
  * description will include the descriptions of any surrounding group()
  * calls.
  */
 void test(String spec, TestFunction body) {
   ensureInitialized();
-  _tests.add(new TestCase(_tests.length + 1, _fullSpec(spec), body, 0));
+  _tests.add(new TestCase._internal(_tests.length + 1, _fullSpec(spec), body));
 }
 
 /**
  * Creates a new test case with the given description and body. The
  * description will include the descriptions of any surrounding group()
  * calls.
  *
  * "solo_" means that this will be the only test that is run. All other tests
  * will be skipped. This is a convenience function to let you quickly isolate
  * a single test by adding "solo_" before it to temporarily disable all other
  * tests.
  */
 void solo_test(String spec, TestFunction body) {
   // TODO(rnystrom): Support multiple solos. If more than one test is solo-ed,
   // all of the solo-ed tests and none of the non-solo-ed ones should run.
   if (_soloTest != null) {
     throw new Exception('Only one test can be soloed right now.');
   }
 
   ensureInitialized();
 
-  _soloTest = new TestCase(_tests.length + 1, _fullSpec(spec), body, 0);
+  _soloTest = new TestCase._internal(_tests.length + 1, _fullSpec(spec), body);
   _tests.add(_soloTest);
 }
 
 /** Sentinel value for [_SpreadArgsHelper]. */
 class _Sentinel {
   const _Sentinel();
 }
 
 /** Simulates spread arguments using named arguments. */
 // TODO(sigmund): remove this class and simply use a closure with named
@@ skipping 25 matching lines @@
            _currentTest < _tests.length &&
            _tests[_currentTest] != null)) {
       print("No valid test, did you forget to run your test inside a call "
           "to test()?");
     }
     assert(_currentTest >= 0 &&
            _currentTest < _tests.length &&
            _tests[_currentTest] != null);
     testCase = _tests[_currentTest];
     if (isDone != null || minExpected > 0) {
-      testCase.callbackFunctionsOutstanding++;
+      testCase._callbackFunctionsOutstanding++;
       complete = false;
     } else {
       complete = true;
     }
   }
 
   static _makeCallbackId(String id, Function callback) {
     // Try to create a reasonable id.
     if (id != null) {
       return "$id ";
@@ skipping 35 matching lines @@
   }
 
   after() {
     if (!complete) {
       if (minExpectedCalls > 0 && actualCalls < minExpectedCalls) return;
       if (isDone != null && !isDone()) return;
 
       // Mark this callback as complete and remove it from the testcase
       // oustanding callback count; if that hits zero the testcase is done.
       complete = true;
-      testCase.markCallbackComplete();
+      testCase._markCallbackComplete();
     }
   }
 
   invoke([arg0 = sentinel, arg1 = sentinel, arg2 = sentinel,
           arg3 = sentinel, arg4 = sentinel]) {
     return _guardAsync(() {
       if (!shouldCallBack()) {
         return;
       } else if (arg0 == sentinel) {
         return callback();
@@ skipping 365 matching lines @@
  * running. Tests will resume executing when such asynchronous test calls
  * [done] or if it fails with an exception.
  */
 _nextBatch() {
   while (true) {
     if (_currentTest >= _tests.length) {
       _completeTests();
       break;
     }
     final testCase = _tests[_currentTest];
-    var f = _guardAsync(testCase.run, null, _currentTest);
+    var f = _guardAsync(testCase._run, null, _currentTest);
     if (f != null) {
       f.whenComplete(() {
         _nextTestCase(); // Schedule the next test.
       });
       break;
     }
     _currentTest++;
   }
 }
 
@@ skipping 75 matching lines @@
 }
 
 /** Enable a test by ID. */
 void enableTest(int testId) => _setTestEnabledState(testId, true);
 
 /** Disable a test by ID. */
 void disableTest(int testId) => _setTestEnabledState(testId, false);
 
 /** Signature for a test function. */
 typedef dynamic TestFunction();