Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: test/unittests/compiler/interpreter-assembler-unittest.cc

Issue 1245133002: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth_bytecode_array
Patch Set: Modified to deal with seperate BytecodeArray and BytecodeOffset registers Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/arm/builtins-arm.cc ('K') | « src/interpreter/interpreter.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "test/unittests/compiler/interpreter-assembler-unittest.h" 5 #include "test/unittests/compiler/interpreter-assembler-unittest.h"
6 6
7 #include "src/compiler/graph.h" 7 #include "src/compiler/graph.h"
8 #include "src/compiler/node.h" 8 #include "src/compiler/node.h"
9 #include "src/unique.h"
9 #include "test/unittests/compiler/compiler-test-utils.h" 10 #include "test/unittests/compiler/compiler-test-utils.h"
10 #include "test/unittests/compiler/node-test-utils.h" 11 #include "test/unittests/compiler/node-test-utils.h"
11 12
12 namespace v8 { 13 namespace v8 {
13 namespace internal { 14 namespace internal {
14 namespace compiler { 15 namespace compiler {
15 16
16 const interpreter::Bytecode kBytecodes[] = { 17 const interpreter::Bytecode kBytecodes[] = {
17 #define DEFINE_BYTECODE(Name, _) interpreter::Bytecode::k##Name, 18 #define DEFINE_BYTECODE(Name, _) interpreter::Bytecode::k##Name,
18 BYTECODE_LIST(DEFINE_BYTECODE) 19 BYTECODE_LIST(DEFINE_BYTECODE)
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 tail_call_node, 80 tail_call_node,
80 IsTailCall(m.call_descriptor(), code_target_matcher, 81 IsTailCall(m.call_descriptor(), code_target_matcher,
81 next_bytecode_offset_matcher, 82 next_bytecode_offset_matcher,
82 IsParameter(Linkage::kInterpreterBytecodeArrayParameter), 83 IsParameter(Linkage::kInterpreterBytecodeArrayParameter),
83 IsParameter(Linkage::kInterpreterDispatchTableParameter), 84 IsParameter(Linkage::kInterpreterDispatchTableParameter),
84 graph->start(), graph->start())); 85 graph->start(), graph->start()));
85 } 86 }
86 } 87 }
87 88
88 89
90 TARGET_TEST_F(InterpreterAssemblerTest, Return) {
91 TRACED_FOREACH(interpreter::Bytecode, bytecode, kBytecodes) {
92 InterpreterAssemblerForTest m(this, bytecode);
93 m.Return();
94 Graph* graph = m.GetCompletedGraph();
95
96 Node* end = graph->end();
97 EXPECT_EQ(1, end->InputCount());
98 Node* tail_call_node = end->InputAt(0);
99
100 EXPECT_EQ(CallDescriptor::kInterpreterDispatch,
101 m.call_descriptor()->kind());
102 Matcher<Unique<HeapObject>> exit_trampoline(
103 Unique<HeapObject>::CreateImmovable(
104 isolate()->builtins()->InterpreterExitTrampoline()));
105 EXPECT_THAT(
106 tail_call_node,
107 IsTailCall(m.call_descriptor(), IsHeapConstant(exit_trampoline),
108 IsParameter(Linkage::kInterpreterBytecodeOffsetParameter),
109 IsParameter(Linkage::kInterpreterBytecodeArrayParameter),
110 IsParameter(Linkage::kInterpreterDispatchTableParameter),
111 graph->start(), graph->start()));
112 }
113 }
114
115
89 TARGET_TEST_F(InterpreterAssemblerTest, BytecodeArg) { 116 TARGET_TEST_F(InterpreterAssemblerTest, BytecodeArg) {
90 TRACED_FOREACH(interpreter::Bytecode, bytecode, kBytecodes) { 117 TRACED_FOREACH(interpreter::Bytecode, bytecode, kBytecodes) {
91 InterpreterAssemblerForTest m(this, bytecode); 118 InterpreterAssemblerForTest m(this, bytecode);
92 int number_of_args = interpreter::Bytecodes::NumberOfArguments(bytecode); 119 int number_of_args = interpreter::Bytecodes::NumberOfArguments(bytecode);
93 for (int i = 0; i < number_of_args; i++) { 120 for (int i = 0; i < number_of_args; i++) {
94 Node* load_arg_node = m.BytecodeArg(i); 121 Node* load_arg_node = m.BytecodeArg(i);
95 EXPECT_THAT( 122 EXPECT_THAT(
96 load_arg_node, 123 load_arg_node,
97 m.IsLoad( 124 m.IsLoad(
98 kMachUint8, 125 kMachUint8,
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 IsInt32Sub(IsInt32Constant(m.kFirstRegisterOffsetFromFp), 191 IsInt32Sub(IsInt32Constant(m.kFirstRegisterOffsetFromFp),
165 IsWord32Shl(reg_index_node, 192 IsWord32Shl(reg_index_node,
166 IsInt32Constant(kPointerSizeLog2))), 193 IsInt32Constant(kPointerSizeLog2))),
167 store_value)); 194 store_value));
168 } 195 }
169 } 196 }
170 197
171 } // namespace compiler 198 } // namespace compiler
172 } // namespace internal 199 } // namespace internal
173 } // namespace v8 200 } // namespace v8
OLDNEW
« src/arm/builtins-arm.cc ('K') | « src/interpreter/interpreter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698