Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1245113005: Rename VPN_PROVIDER_ON_UIEVENT to VPN_PROVIDER_ON_UI_EVENT. (Closed)

Created:
5 years, 5 months ago by not at google - send to devlin
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename VPN_PROVIDER_ON_UIEVENT to VPN_PROVIDER_ON_UI_EVENT. BUG=503402 R=rdevlin.cronin@chromium.org,asvitkine@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/767ff14ddc5c81190d92efb29fa4330c0d7dcef2 Cr-Commit-Position: refs/heads/master@{#339725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M extensions/browser/extension_event_histogram_value.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
not at google - send to devlin
5 years, 5 months ago (2015-07-21 18:40:20 UTC) #1
Devlin
lgtm
5 years, 5 months ago (2015-07-21 18:44:34 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 5 months ago (2015-07-21 19:02:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245113005/1
5 years, 5 months ago (2015-07-21 19:24:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 20:04:00 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 20:05:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/767ff14ddc5c81190d92efb29fa4330c0d7dcef2
Cr-Commit-Position: refs/heads/master@{#339725}

Powered by Google App Engine
This is Rietveld 408576698