Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1245083005: Docserver: Use real BranchUtility for local server instances (Closed)

Created:
5 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Docserver: Use real BranchUtility for local server instances BUG=None Committed: https://crrev.com/2d4a85bf456c70f75bae245eff9652b4e3b250ce Cr-Commit-Position: refs/heads/master@{#339743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/common/extensions/docs/server2/server_instance.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Ken Rockot(use gerrit already)
Ben could you PTAL? I think you said you wanted to do this anyway.
5 years, 5 months ago (2015-07-21 19:30:31 UTC) #2
paulmeyer
On 2015/07/21 19:30:31, Ken Rockot wrote: > Ben could you PTAL? I think you said ...
5 years, 5 months ago (2015-07-21 19:46:44 UTC) #3
not at google - send to devlin
lgtm Sweeet.
5 years, 5 months ago (2015-07-21 20:29:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245083005/1
5 years, 5 months ago (2015-07-21 20:30:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 20:45:45 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 20:46:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d4a85bf456c70f75bae245eff9652b4e3b250ce
Cr-Commit-Position: refs/heads/master@{#339743}

Powered by Google App Engine
This is Rietveld 408576698