Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 1245073003: Make ChromeActivityTestCaseBase#clearAppData() use Instrumentation#getTargetContext() (Closed)

Created:
5 years, 5 months ago by pkotwicz
Modified:
5 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ChromeActivityTestCaseBase#clearAppData() use Instrumentation#getTargetContext() Using Instrumentation#getTargetContext() in ChromeActivityTestCaseBase#clearAppData() is consistent with how ApplicationTestUtils#clearAppData() is called everywhere else. Using Instrumentation#getContext() causes crashiness BUG=505040 TEST=None Committed: https://crrev.com/a803376806c0f5e2a3515ffb2492ebb7b1c229c2 Cr-Commit-Position: refs/heads/master@{#339689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
pkotwicz
dfalcantara@ PTAL. I believe that this CL fixes an unintentional change by https://codereview.chromium.org/1223323012
5 years, 5 months ago (2015-07-21 17:01:51 UTC) #2
gone
lgtm
5 years, 5 months ago (2015-07-21 17:07:49 UTC) #3
gone
Good catch!
5 years, 5 months ago (2015-07-21 17:07:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245073003/1
5 years, 5 months ago (2015-07-21 17:12:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 17:43:28 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 17:45:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a803376806c0f5e2a3515ffb2492ebb7b1c229c2
Cr-Commit-Position: refs/heads/master@{#339689}

Powered by Google App Engine
This is Rietveld 408576698