Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1245063002: libwebp: cherry-pick -Wincompatible-pointer fix (Closed)

Created:
5 years, 5 months ago by jzern
Modified:
5 years, 5 months ago
Reviewers:
urvang
CC:
chromium-reviews, jzern, skal, vikasa, Sam McNally
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libwebp: cherry-pick -Wincompatible-pointer fix msvc: fix pointer type warning in BitsLog2Floor _BitScanReverse() takes an unsigned long* http://msdn.microsoft.com/en-us/library/fbxyd7zd.aspx fixes: C4057: 'function': 'unsigned long *' differs in indirection to slightly different base types from 'uint32_t *' and -Wincompatible-pointer-types warning on Clang on Windows https://code.google.com/p/webp/issues/detail?id=253 Committed: https://crrev.com/dc63ece9abb8f6706e719fb7d4aa3472fc75269b Cr-Commit-Position: refs/heads/master@{#339716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/libwebp/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libwebp/utils/utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
urvang
lgtm
5 years, 5 months ago (2015-07-21 19:20:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245063002/1
5 years, 5 months ago (2015-07-21 19:21:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 19:31:35 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 19:49:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc63ece9abb8f6706e719fb7d4aa3472fc75269b
Cr-Commit-Position: refs/heads/master@{#339716}

Powered by Google App Engine
This is Rietveld 408576698