Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1245043003: Fix pushing of register in CallConstructStub outside frame. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix pushing of register in CallConstructStub outside frame. This fixes a recent regression where the register holding the original receiver was pushed onto the stack before the internal frame within the CallStubInRecordCallTarget helper was created. That in turn confused the stack walker when allocations in these stubs failed. R=mvstanton@chromium.org BUG=chromium:512711 LOG=N Committed: https://crrev.com/1f295980b7ac309dcef732088ae363722277a408 Cr-Commit-Position: refs/heads/master@{#29787}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -118 lines) Patch
M src/ia32/code-stubs-ia32.cc View 1 4 chunks +40 lines, -21 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 6 chunks +31 lines, -33 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 6 chunks +33 lines, -34 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 7 chunks +33 lines, -30 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
For ARM and ARM64 this is subsumed by the combination of: - https://codereview.chromium.org/1241223003/ - https://codereview.chromium.org/1244023002/ ...
5 years, 5 months ago (2015-07-22 10:42:12 UTC) #1
mvstanton
lgtm. https://codereview.chromium.org/1245043003/diff/20001/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): https://codereview.chromium.org/1245043003/diff/20001/src/x64/code-stubs-x64.cc#newcode1795 src/x64/code-stubs-x64.cc:1795: // rdi : the function to call edi, ...
5 years, 5 months ago (2015-07-22 10:53:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1245043003/20001
5 years, 5 months ago (2015-07-22 10:57:42 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 11:10:55 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 11:11:21 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f295980b7ac309dcef732088ae363722277a408
Cr-Commit-Position: refs/heads/master@{#29787}

Powered by Google App Engine
This is Rietveld 408576698