Issue 124503002: Roll Skia DEPS to r12906

Issue 124503002: Roll Skia DEPS to r12906 (Closed)

Created:
6 years, 11 months ago by robertphillips

Modified:
6 years, 11 months ago

Reviewers:
Stephen White, reed1, rmistry, senorblanco, bsalomon

CC:
chromium-reviews, skia-team_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Roll Skia DEPS to r12906 R=reed@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243096

Patch Set 1 #

Patch Set 2 : Patch bitmap_platform_device_win.cc #

Patch Set 3 : Add suppressions #

Patch Set 4 : Roll to 12906 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
M	DEPS	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	skia/skia_common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	skia/skia_test_expectations.txt	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

control: https://codereview.chromium.org/107063004/

6 years, 11 months ago (2014-01-04 14:06:35 UTC) #1

robertphillips

This is blocked on the Windows compilation issues (Mike?) and the effect-reference-subregion layout tests (Stephen?). ...

6 years, 11 months ago (2014-01-05 16:47:34 UTC) #2

This is blocked on the Windows compilation issues (Mike?) and the
effect-reference-subregion layout tests (Stephen?).

android_dbg
   roll:    
            slave_steps
            webkit_unit_tests 
            androidwebview_instrumentation_tests 
            contentshell_instrumentation_tests 
   control: 
            green

mac
   roll:    
            buildrunner_tests
            webkit_unit_tests crashed or hung *****************
   control: 
            buildrunner_tests 
            telemetry_unittests failed 1
                testBasicHostingAndRangeRequests

mac_asan
   roll:    
            buildrunner_tests 
            telemetry_unittests failed 3
                testCommandLineOverriding
                testMultipleTabCalls
                testBasicHostingAndRangeRequests
            content_browsertests 36 flaky failed 23
                VideoBearOpusOgg_0
                VideoBearOpusWebm_0
                VideoBearTheora_0
                VideoBearWavAlaw_0
                VideoBearWavMulaw_0
                VideoBearWebm_0
                CopyFromCompositingSurface_CallbackDespiteDelete_0
                CopyTwice_0
                ConnectionsClosedOnTabClose
                CursorPrefetch
                KeyTypesTest
                PRE_VersionChangeCrashResilience
                VersionChangeCrashResilience
                Yuv420pTheora
                CrossFrameFormBackForward
                FrameBackForward
                FrameFormBackForward
                HistoryLength
                JavascriptHistory
                LocationReplace
                OneShotRecognition
                MultipleSharedWorkers
                SingleSharedWorker
            webkit_unit_tests crashed or hung
            nacl_integration 
   control: 
            buildrunner_tests 
            telemetry_unittests failed 2
                testMultipleTabCalls
                testBasicHostingAndRangeRequests
            content_browsertests 5 flaky failed 1
                ResumeWithFileFinalRenameError
            nacl_integration 

win
   roll:    
            compile failed 
               
e:\b\build\slave\win\build\src\skia\ext\bitmap_platform_device_win.cc(127) :
error C2660: 'SkPixelRef::setPreLocked' : function does not take 2 arguments
   control: 
            buildrunner_tests 
            telemetry_unittests failed 2
                testMultipleTabCalls
                testBasicHostingAndRangeRequests
            content_browsertests 4 flaky failed 1
                LimitTotal
            nacl_integration

win_gpu
   roll:    
            running steps via annotated script
                compile
                skia\ext\bitmap_platform_device_win.cc(127) : error C2660:
'SkPixelRef::setPreLocked' : function does not take 2 arguments
   control: 
            green

linux_layout
   roll:    
            webkit_tests 432 fixable (0 skipped) failed 2
                effect-reference-subregion-chained-hw.html 
                effect-reference-subregion-hw.html 
            buildrunner_tests 
            webkit_unit_tests crashed or hung 
   control: 
            green

linux_layout_rel
   roll:    
            webkit_tests 397 fixable (0 skipped) failed 2
                effect-reference-subregion-chained-hw.html 
                effect-reference-subregion-hw.html 
            buildrunner_tests 
            webkit_unit_tests crashed or hung 
   control: 
            green

mac_layout
   roll:    
            webkit_tests 848 fixable (0 skipped) failed 2
                effect-reference-subregion-chained-hw.html 
                effect-reference-subregion-hw.html 
            buildrunner_tests 
            webkit_unit_tests crashed or hung 
   control: 
            green

mac_layout_rel
   roll:    
            webkit_tests 828 fixable (0 skipped) failed 2
                effect-reference-subregion-chained-hw.html 
                effect-reference-subregion-hw.html 
   control: 
            green

win_layout
   roll:    
            compile failed 
            skia\ext\bitmap_platform_device_win.cc(127) : error C2660:
'SkPixelRef::setPreLocked' : function does not take 2 arguments
   control: 
            webkit_tests 378 fixable (0 skipped) failed 2
                appcache-swap.html 
                online-whitelist.html 

win_layout_rel
   roll:    
            compile failed
            skia\ext\bitmap_platform_device_win.cc(127) : error C2660:
'SkPixelRef::setPreLocked' : function does not take 2 arguments
   control: 
            green

robertphillips

It also looks like the webkit_unit_test failures are ours also: [ RUN ] ImageDecodingStoreTest.insertGenerationCollisionAfterMemoryDiscarded Received ...

6 years, 11 months ago (2014-01-05 16:50:21 UTC) #3

Stephen White

On 2014/01/05 16:47:34, robertphillips wrote: > This is blocked on the Windows compilation issues (Mike?) ...

6 years, 11 months ago (2014-01-05 17:22:16 UTC) #4

On 2014/01/05 16:47:34, robertphillips wrote:
> This is blocked on the Windows compilation issues (Mike?) and the
> effect-reference-subregion layout tests (Stephen?).

Those should be suppressed in skia_test_expectations.txt until I can rebaseline
them in Blink, as per the note  in https://codereview.chromium.org/112803004/.

Stephen

> 
> android_dbg
>    roll:    
>             slave_steps
>             webkit_unit_tests 
>             androidwebview_instrumentation_tests 
>             contentshell_instrumentation_tests 
>    control: 
>             green
> 
> mac
>    roll:    
>             buildrunner_tests
>             webkit_unit_tests crashed or hung *****************
>    control: 
>             buildrunner_tests 
>             telemetry_unittests failed 1
>                 testBasicHostingAndRangeRequests
> 
> mac_asan
>    roll:    
>             buildrunner_tests 
>             telemetry_unittests failed 3
>                 testCommandLineOverriding
>                 testMultipleTabCalls
>                 testBasicHostingAndRangeRequests
>             content_browsertests 36 flaky failed 23
>                 VideoBearOpusOgg_0
>                 VideoBearOpusWebm_0
>                 VideoBearTheora_0
>                 VideoBearWavAlaw_0
>                 VideoBearWavMulaw_0
>                 VideoBearWebm_0
>                 CopyFromCompositingSurface_CallbackDespiteDelete_0
>                 CopyTwice_0
>                 ConnectionsClosedOnTabClose
>                 CursorPrefetch
>                 KeyTypesTest
>                 PRE_VersionChangeCrashResilience
>                 VersionChangeCrashResilience
>                 Yuv420pTheora
>                 CrossFrameFormBackForward
>                 FrameBackForward
>                 FrameFormBackForward
>                 HistoryLength
>                 JavascriptHistory
>                 LocationReplace
>                 OneShotRecognition
>                 MultipleSharedWorkers
>                 SingleSharedWorker
>             webkit_unit_tests crashed or hung
>             nacl_integration 
>    control: 
>             buildrunner_tests 
>             telemetry_unittests failed 2
>                 testMultipleTabCalls
>                 testBasicHostingAndRangeRequests
>             content_browsertests 5 flaky failed 1
>                 ResumeWithFileFinalRenameError
>             nacl_integration 
> 
> win
>    roll:    
>             compile failed 
>                
> e:\b\build\slave\win\build\src\skia\ext\bitmap_platform_device_win.cc(127) :
> error C2660: 'SkPixelRef::setPreLocked' : function does not take 2 arguments
>    control: 
>             buildrunner_tests 
>             telemetry_unittests failed 2
>                 testMultipleTabCalls
>                 testBasicHostingAndRangeRequests
>             content_browsertests 4 flaky failed 1
>                 LimitTotal
>             nacl_integration
> 
> win_gpu
>    roll:    
>             running steps via annotated script
>                 compile
>                 skia\ext\bitmap_platform_device_win.cc(127) : error C2660:
> 'SkPixelRef::setPreLocked' : function does not take 2 arguments
>    control: 
>             green
> 
> linux_layout
>    roll:    
>             webkit_tests 432 fixable (0 skipped) failed 2
>                 effect-reference-subregion-chained-hw.html 
>                 effect-reference-subregion-hw.html 
>             buildrunner_tests 
>             webkit_unit_tests crashed or hung 
>    control: 
>             green
> 
> linux_layout_rel
>    roll:    
>             webkit_tests 397 fixable (0 skipped) failed 2
>                 effect-reference-subregion-chained-hw.html 
>                 effect-reference-subregion-hw.html 
>             buildrunner_tests 
>             webkit_unit_tests crashed or hung 
>    control: 
>             green
> 
> mac_layout
>    roll:    
>             webkit_tests 848 fixable (0 skipped) failed 2
>                 effect-reference-subregion-chained-hw.html 
>                 effect-reference-subregion-hw.html 
>             buildrunner_tests 
>             webkit_unit_tests crashed or hung 
>    control: 
>             green
> 
> mac_layout_rel
>    roll:    
>             webkit_tests 828 fixable (0 skipped) failed 2
>                 effect-reference-subregion-chained-hw.html 
>                 effect-reference-subregion-hw.html 
>    control: 
>             green
> 
> win_layout
>    roll:    
>             compile failed 
>             skia\ext\bitmap_platform_device_win.cc(127) : error C2660:
> 'SkPixelRef::setPreLocked' : function does not take 2 arguments
>    control: 
>             webkit_tests 378 fixable (0 skipped) failed 2
>                 appcache-swap.html 
>                 online-whitelist.html 
> 
> win_layout_rel
>    roll:    
>             compile failed
>             skia\ext\bitmap_platform_device_win.cc(127) : error C2660:
> 'SkPixelRef::setPreLocked' : function does not take 2 arguments
>    control: 
>             green

robertphillips

6 years, 11 months ago (2014-01-06 16:08:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r243096 (presubmit successful).

Expand Messages | Collapse Messages