Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1245023004: fixes dart.throw to work for non-objects (Closed)

Created:
5 years, 5 months ago by Jennifer Messerly
Modified:
5 years, 5 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes dart.throw to work for non-objects language tests use this, for example R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/eecdbe4fed26f37e020eb2315f532794cfd35588

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M lib/runtime/_operations.js View 1 1 chunk +9 lines, -4 lines 2 comments Download
M test/browser/runtime_tests.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jennifer Messerly
5 years, 5 months ago (2015-07-22 23:19:40 UTC) #2
Jennifer Messerly
on weakmap: it should be a bit better for expando like things added to object ...
5 years, 5 months ago (2015-07-22 23:21:30 UTC) #3
vsm
lgtm https://codereview.chromium.org/1245023004/diff/20001/lib/runtime/_operations.js File lib/runtime/_operations.js (right): https://codereview.chromium.org/1245023004/diff/20001/lib/runtime/_operations.js#newcode277 lib/runtime/_operations.js:277: // allow it to work for things like ...
5 years, 5 months ago (2015-07-23 14:00:04 UTC) #4
Jennifer Messerly
https://codereview.chromium.org/1245023004/diff/20001/lib/runtime/_operations.js File lib/runtime/_operations.js (right): https://codereview.chromium.org/1245023004/diff/20001/lib/runtime/_operations.js#newcode277 lib/runtime/_operations.js:277: // allow it to work for things like strings ...
5 years, 5 months ago (2015-07-23 15:51:30 UTC) #5
Jennifer Messerly
5 years, 5 months ago (2015-07-23 16:34:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eecdbe4fed26f37e020eb2315f532794cfd35588 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698