tool/analyze.sh - Issue 1245013002: some fixes for --strong warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/analyze.sh

Issue 1245013002: some fixes for --strong warnings (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/analyze.sh

diff --git a/tool/analyze.sh b/tool/analyze.sh

index 7f1b35e24a38ac3b200ff6fb3ed11ffd88a12232..8b46f72c388b86edeb20f7aab3f9d3fbfe9d0fc8 100755

--- a/tool/analyze.sh

+++ b/tool/analyze.sh

@@ -15,5 +15,5 @@ function fail {

# TODO(jmesserly): ideally we could do test/all_tests.dart, but

# dart_runtime_test.dart creates invalid generic type instantiation AA.

echo "Running dartanalyzer to check for errors/warnings/hints..."

-dartanalyzer --fatal-warnings --package-warnings bin/devc.dart | (! grep $PWD) \

- || fail

+dartanalyzer --fatal-warnings --package-warnings bin/devc.dart \

+ | (! grep $PWD) || fail

« lib/src/server/dependency_graph.dart ('K') | « lib/src/utils.dart ('k') | no next file » | no next file with comments »