Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 12450003: Separate output files for --trace-hydrogen. (Closed)

Created:
7 years, 9 months ago by Sven Panne
Modified:
7 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Separate output files for --trace-hydrogen. The output filenames have now the form "hydrogen-<ProcessId>-<IsolateId>.cfg". Minor cleanup on the way. Note that we have a similar bug regarding statistics, but this will be handled in a separate CL. BUG=v8:2563 Committed: http://code.google.com/p/v8/source/detail?r=13834

Patch Set 1 #

Patch Set 2 : Some simplifications #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -56 lines) Patch
M src/code-stubs-hydrogen.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M src/hydrogen.h View 3 chunks +19 lines, -31 lines 0 comments Download
M src/hydrogen.cc View 5 chunks +44 lines, -15 lines 0 comments Download
M src/isolate.h View 5 chunks +10 lines, -0 lines 0 comments Download
M src/isolate.cc View 4 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 9 months ago (2013-03-05 15:42:57 UTC) #1
Toon Verwaest
Nice cleanup! lgtm.
7 years, 9 months ago (2013-03-05 17:25:34 UTC) #2
Sven Panne
7 years, 9 months ago (2013-03-06 07:25:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r13834 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698