Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1244983003: Make mojo dart controller depend on tonic and get building without wtf (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make mojo dart controller depend on tonic and get building without wtf R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/040a7ed7976c04d6b5c89f794c74ba3a054933ed

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -412 lines) Patch
M mojo/dart/embedder/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tonic/BUILD.gn View 2 chunks +25 lines, -7 lines 0 comments Download
M tonic/dart_converter.h View 1 2 3 chunks +9 lines, -189 lines 0 comments Download
A + tonic/dart_converter_wtf.h View 2 chunks +15 lines, -187 lines 0 comments Download
A + tonic/dart_converter_wtf.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M tonic/dart_library_loader.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M tonic/dart_state.h View 3 chunks +0 lines, -3 lines 0 comments Download
M tonic/dart_state.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M tonic/dart_wrappable.h View 1 chunk +0 lines, -11 lines 0 comments Download
M tonic/float32_list.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 5 months ago (2015-07-20 21:47:30 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1244983003/diff/1/tonic/dart_converter.h File tonic/dart_converter.h (right): https://codereview.chromium.org/1244983003/diff/1/tonic/dart_converter.h#newcode185 tonic/dart_converter.h:185: uint8_t* data = NULL; nullptr https://codereview.chromium.org/1244983003/diff/1/tonic/dart_converter.h#newcode192 tonic/dart_converter.h:192: static_cast<size_t>(length)); ...
5 years, 5 months ago (2015-07-20 22:49:18 UTC) #4
Cutch
https://codereview.chromium.org/1244983003/diff/1/tonic/dart_converter.h File tonic/dart_converter.h (right): https://codereview.chromium.org/1244983003/diff/1/tonic/dart_converter.h#newcode185 tonic/dart_converter.h:185: uint8_t* data = NULL; On 2015/07/20 22:49:18, abarth-chromium wrote: ...
5 years, 5 months ago (2015-07-21 13:55:31 UTC) #5
Cutch
5 years, 5 months ago (2015-07-21 13:55:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
040a7ed7976c04d6b5c89f794c74ba3a054933ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698