Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 124493002: content: Add layout_test_helper target. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

content: Add layout_test_helper target. This should build the layout test files that were copied from Blink over here. BUG=331304 TEST=builds R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243043

Patch Set 1 #

Patch Set 2 : layout_test_helper #

Patch Set 3 : make blink_tests depend on them #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M build/all.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/content_shell.gypi View 1 2 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 11 months ago (2014-01-04 16:44:25 UTC) #1
jochen (gone - plz use gerrit)
can you make blink_tests in build/all.gyp depend on this target for mac and win?
6 years, 11 months ago (2014-01-04 19:50:22 UTC) #2
tfarina
On 2014/01/04 19:50:22, jochen wrote: > can you make blink_tests in build/all.gyp depend on this ...
6 years, 11 months ago (2014-01-05 12:59:39 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-05 15:55:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/124493002/2
6 years, 11 months ago (2014-01-05 16:44:49 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-05 19:04:45 UTC) #6
Message was sent while issue was closed.
Change committed as 243043

Powered by Google App Engine
This is Rietveld 408576698