Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: include/llvm/Analysis/NaCl.h

Issue 12449014: ABI verifier: Add standalone tool pnacl-abicheck (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/llvm/Analysis/NaCl.h
diff --git a/include/llvm/Analysis/NaCl.h b/include/llvm/Analysis/NaCl.h
index 8e599594b2716ca2747f0db0c48ca3f86dd821dd..876e5ac4e738da359ffd1e18e0bcb7d220cb9bc8 100644
--- a/include/llvm/Analysis/NaCl.h
+++ b/include/llvm/Analysis/NaCl.h
@@ -10,13 +10,23 @@
#ifndef LLVM_ANALYSIS_NACL_H
#define LLVM_ANALYSIS_NACL_H
+#include "llvm/Pass.h"
+
namespace llvm {
-class FunctionPass;
-class ModulePass;
+// Interface to get verification results from module verifier passes.
+// Separated from the logic of the pass itself to
Mark Seaborn 2013/03/12 22:25:56 Incomplete sentence?
Derek Schuff 2013/03/13 21:51:01 Done.
+class PNaClABIVerifierPass {
+ public:
+ // ABI verifier errors will immediately print out the error and
+ // cause the pass to return true, aborting compilation. Call before running.
+ virtual void setStrict(bool Strict) = 0;
+ // Return the number of errors from the
Mark Seaborn 2013/03/12 22:25:56 ditto
Derek Schuff 2013/03/13 21:51:01 Done.
+ virtual int getErrorCount() = 0;
+};
-FunctionPass *createPNaClABIVerifyFunctionsPass();
-ModulePass *createPNaClABIVerifyModulePass();
+FunctionPass *createPNaClABIVerifyFunctionsPass(bool Strict);
+ModulePass *createPNaClABIVerifyModulePass(bool Strict);
}
« no previous file with comments | « no previous file | lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp » ('j') | lib/Analysis/NaCl/PNaClABIVerifyModule.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698