Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 12449014: ABI verifier: Add standalone tool pnacl-abicheck (Closed)

Created:
7 years, 9 months ago by Derek Schuff
Modified:
7 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

ABI verifier: Add standalone tool pnacl-abicheck This CL adds a standalone tool pnacl-abicheck for checking the ABI validity of a bitcode file. It also adds a flag pnaclabi-verify to llc to enable the same checking in llc. It also improves the mechanism for handling and reporting validation errors and uses it in both tools. R=jvoung@chromium.org,mseaborn@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=2309 Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=cb0dcd0

Patch Set 1 #

Total comments: 18

Patch Set 2 : add pnacl-abicheck standalone tool #

Total comments: 2

Patch Set 3 : cleanup, use << for error streams uniformly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -68 lines) Patch
M include/llvm/Analysis/NaCl.h View 1 1 chunk +33 lines, -2 lines 0 comments Download
M lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp View 1 2 7 chunks +39 lines, -26 lines 0 comments Download
M lib/Analysis/NaCl/PNaClABIVerifyModule.cpp View 1 2 6 chunks +52 lines, -33 lines 0 comments Download
M tools/CMakeLists.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/LLVMBuild.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/llc/llc.cpp View 1 9 chunks +41 lines, -0 lines 0 comments Download
A tools/pnacl-abicheck/CMakeLists.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + tools/pnacl-abicheck/LLVMBuild.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + tools/pnacl-abicheck/Makefile View 1 2 chunks +4 lines, -3 lines 0 comments Download
A tools/pnacl-abicheck/pnacl-abicheck.cpp View 1 2 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Derek Schuff
Next CL will be a simple standalone checker.
7 years, 9 months ago (2013-03-12 21:54:58 UTC) #1
jvoung (off chromium)
https://codereview.chromium.org/12449014/diff/1/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp File lib/Analysis/NaCl/PNaClABIVerifyModule.cpp (right): https://codereview.chromium.org/12449014/diff/1/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp#newcode28 lib/Analysis/NaCl/PNaClABIVerifyModule.cpp:28: class PNaClABIVerifyModule : public ModulePass, public PNaClABIVerifierPass { Only ...
7 years, 9 months ago (2013-03-12 22:16:21 UTC) #2
Mark Seaborn
https://codereview.chromium.org/12449014/diff/1/include/llvm/Analysis/NaCl.h File include/llvm/Analysis/NaCl.h (right): https://codereview.chromium.org/12449014/diff/1/include/llvm/Analysis/NaCl.h#newcode18 include/llvm/Analysis/NaCl.h:18: // Separated from the logic of the pass itself ...
7 years, 9 months ago (2013-03-12 22:25:56 UTC) #3
Derek Schuff
(previously: ABI verifier: Add option for fatal error on violation, llc flag to use it) ...
7 years, 9 months ago (2013-03-13 21:51:01 UTC) #4
jvoung (off chromium)
https://codereview.chromium.org/12449014/diff/1/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp File lib/Analysis/NaCl/PNaClABIVerifyModule.cpp (right): https://codereview.chromium.org/12449014/diff/1/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp#newcode89 lib/Analysis/NaCl/PNaClABIVerifyModule.cpp:89: ErrorCount++; The new version seems good. If you are ...
7 years, 9 months ago (2013-03-13 22:40:09 UTC) #5
Derek Schuff
https://codereview.chromium.org/12449014/diff/1/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp File lib/Analysis/NaCl/PNaClABIVerifyModule.cpp (right): https://codereview.chromium.org/12449014/diff/1/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp#newcode89 lib/Analysis/NaCl/PNaClABIVerifyModule.cpp:89: ErrorCount++; On 2013/03/13 22:40:09, jvoung (cr) wrote: > The ...
7 years, 9 months ago (2013-03-13 22:52:23 UTC) #6
jvoung (off chromium)
lgtm
7 years, 9 months ago (2013-03-13 23:02:52 UTC) #7
Derek Schuff
7 years, 9 months ago (2013-03-13 23:04:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as rcb0dcd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698