NaCl Debugger: Implement overview and filters, cleanup

trunk/debugger/SkDebugger.h

Index: trunk/debugger/SkDebugger.h
===================================================================
--- trunk/debugger/SkDebugger.h	(revision 7896)
+++ trunk/debugger/SkDebugger.h	(working copy)
@@ -12,6 +12,7 @@
 
 #include "SkDebugCanvas.h"
 #include "SkPicture.h"

[robertphillips, 2013/03/07 22:19:11]

probably only need "class SkString;" here

[borenet, 2013/03/08 13:00:26]

Done.

+#include "SkString.h"
 #include "SkTArray.h"
 
 class SkDebugger {
@@ -105,6 +106,7 @@
         }
     }
 
+    void getOverviewText(const SkTDArray<double>* typeTimes, double totTime, SkString& overview);

[borenet, 2013/03/07 21:38:08]

Better to modify a passed-in string in place, or to return a pointer to a new
string?

[djsollen, 2013/03/07 21:50:22]

modify in place.

[djsollen, 2013/03/07 21:50:22]

modify in place if you can initially alloc more than you may need to avoid
having to re-alloc the memory each time.

[borenet, 2013/03/08 13:00:26]

In a future CL I'll estimate the right size to allocate initially.

 
 private:
     SkDebugCanvas* fDebugCanvas;