Issue 12449006: NaCl Debugger: Implement overview and filters, cleanup

Issue 12449006: NaCl Debugger: Implement overview and filters, cleanup (Closed)

Created:
7 years, 9 months ago by borenet

Modified:
7 years, 9 months ago

Reviewers:
djsollen, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

NaCl Debugger: Implement overview and filters, cleanup (SkipBuildbotRuns) since no bots build the debugger. Committed: https://code.google.com/p/skia/source/detail?r=8095

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -120 lines)			Patch
M	nacl/debugger/debugger.css	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	nacl/debugger/index.html	View		7 chunks	+112 lines, -27 lines	0 comments	Download
M	nacl/src/nacl_debugger.cpp	View	1	3 chunks	+23 lines, -9 lines	0 comments	Download
M	nacl/src/nacl_interface.cpp	View		3 chunks	+9 lines, -4 lines	0 comments	Download
M	trunk/debugger/QT/SkDebuggerGUI.cpp	View	1	1 chunk	+3 lines, -78 lines	0 comments	Download
M	trunk/debugger/SkDebugger.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	trunk/debugger/SkDebugger.cpp	View	1	2 chunks	+82 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

borenet

https://codereview.chromium.org/12449006/diff/1/nacl/debugger/index.html File nacl/debugger/index.html (right): https://codereview.chromium.org/12449006/diff/1/nacl/debugger/index.html#newcode1 nacl/debugger/index.html:1: <!DOCTYPE html> At some point, I should find and ...

7 years, 9 months ago (2013-03-07 21:38:08 UTC) #1

djsollen

7 years, 9 months ago (2013-03-07 21:50:22 UTC) #2

robertphillips

https://codereview.chromium.org/12449006/diff/1/trunk/debugger/QT/SkDebuggerGUI.cpp File trunk/debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/12449006/diff/1/trunk/debugger/QT/SkDebuggerGUI.cpp#newcode1074 trunk/debugger/QT/SkDebuggerGUI.cpp:1074: SkString overview; &overview? https://codereview.chromium.org/12449006/diff/1/trunk/debugger/SkDebugger.cpp File trunk/debugger/SkDebugger.cpp (right): https://codereview.chromium.org/12449006/diff/1/trunk/debugger/SkDebugger.cpp#newcode50 trunk/debugger/SkDebugger.cpp:50: ...

7 years, 9 months ago (2013-03-07 22:19:11 UTC) #3

borenet

Patch set 2. https://codereview.chromium.org/12449006/diff/1/nacl/debugger/index.html File nacl/debugger/index.html (right): https://codereview.chromium.org/12449006/diff/1/nacl/debugger/index.html#newcode1 nacl/debugger/index.html:1: <!DOCTYPE html> On 2013/03/07 21:50:22, djsollen ...

7 years, 9 months ago (2013-03-08 13:00:25 UTC) #4

borenet

7 years, 9 months ago (2013-03-12 13:08:01 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r8095 (presubmit successful).

Expand Messages | Collapse Messages