Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1244883002: Fix dxva_video_decode_accelerator.cc to compile with Win 10 SDK (Closed)

Created:
5 years, 5 months ago by brucedawson
Modified:
5 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dxva_video_decode_accelerator.cc to compile with Win 10 SDK dxva_video_decode_accelerator.cc defines CLSID_VideoProcessorMFT, and so does mfidl.h in the Windows 10 SDK. This change uses VER_PRODUCTBUILD to detect the SDK version so that this source file can build with the Windows 8.1 and Windows 10 SDKs. R=dalecurtis@chromium.org BUG=491424 Committed: https://crrev.com/3ab481ec3953f63cfc1ec066eafd788d061f7834 Cr-Commit-Position: refs/heads/master@{#339505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
brucedawson
5 years, 5 months ago (2015-07-20 18:44:06 UTC) #1
DaleCurtis
lgtm
5 years, 5 months ago (2015-07-20 18:46:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244883002/1
5 years, 5 months ago (2015-07-20 20:08:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 20:30:36 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 20:31:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ab481ec3953f63cfc1ec066eafd788d061f7834
Cr-Commit-Position: refs/heads/master@{#339505}

Powered by Google App Engine
This is Rietveld 408576698