Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5474)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/common/ssl_status_serialization.h

Issue 1244863003: Attach a SecurityStyle to each request in ResourceLoader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update forgotten SerializeSecurityInfo() callsite Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/ssl/ssl_policy.cc ('K') | « content/browser/ssl/ssl_policy.cc ('k') | content/common/ssl_status_serialization.cc » ('j') | content/common/ssl_status_serialization.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/ssl_status_serialization.h
diff --git a/content/common/ssl_status_serialization.h b/content/common/ssl_status_serialization.h
index 08819d336277969f85daae266919e0871597d02f..809d97578edb92843831e7a74f4f807f6f2342b7 100644
--- a/content/common/ssl_status_serialization.h
+++ b/content/common/ssl_status_serialization.h
@@ -15,6 +15,7 @@ namespace content {
// Serializes the given security info.
CONTENT_EXPORT std::string SerializeSecurityInfo(
davidben 2015/07/22 20:56:58 Why not just take an SSLStatus as input?
estark 2015/07/22 22:56:55 Done.
+ SecurityStyle security_style,
int cert_id,
net::CertStatus cert_status,
int security_bits,
@@ -23,8 +24,8 @@ CONTENT_EXPORT std::string SerializeSecurityInfo(
signed_certificate_timestamp_ids);
// Deserializes the given security info into |ssl_status|. Note that
-// this returns the SecurityStyle and ContentStatus fields with default
-// values. Returns true on success and false if the state couldn't be
+// this returns the |content_status| field with its default
+// value. Returns true on success and false if the state couldn't be
// deserialized. If false, all fields in |ssl_status| will be set to their
// default values.
bool CONTENT_EXPORT
« content/browser/ssl/ssl_policy.cc ('K') | « content/browser/ssl/ssl_policy.cc ('k') | content/common/ssl_status_serialization.cc » ('j') | content/common/ssl_status_serialization.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698