Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1244843004: Avoid double-counting in GpuChannel memory tracking. (Closed)

Created:
5 years, 5 months ago by ericrk
Modified:
5 years, 5 months ago
Reviewers:
ccameron
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid double-counting in GpuChannel memory tracking. GpuChannel currently calculates current memory usage by iterating over all stubs and summing their individual memory usage. This results in double counting as a given stub may share its memory tracker with other stubs, if they are in a share group. To avoid double counting, we now iterate over stubs to collect a set of unique MemoryTrackers, then sum the memory usage of each unique tracker. BUG=512535 Committed: https://crrev.com/be3028d759f1ef49520f3466b92656af36e7c1de Cr-Commit-Position: refs/heads/master@{#339746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M content/common/gpu/gpu_channel.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ericrk
5 years, 5 months ago (2015-07-21 19:06:36 UTC) #4
ccameron
Nice -- lgtm.
5 years, 5 months ago (2015-07-21 19:39:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244843004/1
5 years, 5 months ago (2015-07-21 19:52:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 21:06:24 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:07:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be3028d759f1ef49520f3466b92656af36e7c1de
Cr-Commit-Position: refs/heads/master@{#339746}

Powered by Google App Engine
This is Rietveld 408576698