Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3380)

Issue 1244843002: Allow ClassName_methodName for a message name, easier to disambiguate duplicates (Closed)

Created:
5 years ago by Alan Knight
Modified:
5 years ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/intl.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow ClassName_methodName for a message name, easier to disambiguate duplicates BUG= R=kevmoo@google.com Committed: https://github.com/dart-lang/intl/commit/f1919d8ec2f6e75ec595b464d3abcd5588c6c138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -15 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M README.md View 1 chunk +2 lines, -1 line 0 comments Download
M lib/intl.dart View 1 chunk +10 lines, -6 lines 0 comments Download
M lib/src/intl_message.dart View 1 chunk +17 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/message_extraction/make_hardcoded_translation.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/message_extraction/part_of_sample_with_messages.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
kevmoo
lgtm
5 years ago (2015-07-23 18:22:27 UTC) #2
Alan Knight
5 years ago (2015-07-23 19:32:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1919d8ec2f6e75ec595b464d3abcd5588c6c138 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698