Issue 1244823003: Remove dependency from //mojo to //crypto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1244823003: Remove dependency from //mojo to //crypto (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Cutch

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove dependency from //mojo to //crypto Turns out we only use crypto::RandBytes, which just calls through to base::RandBytes. This CL changes //mojo to just use base::RandBytes directly. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/bf6adc6f0ac435c538eb7caeddf3bfae1f154568

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -16 lines)			Patch
M	mojo/dart/embedder/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/dart/embedder/builtin_natives.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/dart/embedder/dart_controller.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/dart/embedder/test/BUILD.gn	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	mojo/dart/embedder/test/dart_to_cpp_tests.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/dart/embedder/test/run_dart_tests.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/dart/embedder/test/validation_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/embedder/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/edk/embedder/simple_platform_support.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-20 16:43:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bf6adc6f0ac435c538eb7caeddf3bfae1f154568 (presubmit successful).

Expand Messages | Collapse Messages