Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1244823002: PPC: Debugger: prepare code for debugging on a per-function basis. (Closed)

Created:
5 years, 5 months ago by MTBrandyberry
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Debugger: prepare code for debugging on a per-function basis. Port 35c28ce0a742e58346d2dea009428cacd442040d Original commit message: Prior to this patch, we enter a global debug mode whenever a break point is set. By entering this mode, all code is deoptimized and activated frames are recompiled and redirected to newly compiled debug code. After this patch, we only deoptimize/redirect for functions we want to debug. Trigger for this is Debug::EnsureDebugInfo, and having DebugInfo object attached to the SFI prevents optimization/inlining. The result is that we can have optimized code for functions without break points alongside functions that do have break points, which are not optimized. R=yangguo@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4132 LOG=N Committed: https://crrev.com/9c269424278be4ae555e8af3a00c80ac59c3a33e Cr-Commit-Position: refs/heads/master@{#29764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/ppc/assembler-ppc-inl.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 5 months ago (2015-07-20 16:21:16 UTC) #1
dstence
lgtm
5 years, 5 months ago (2015-07-20 16:46:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244823002/1
5 years, 5 months ago (2015-07-20 16:57:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 17:20:54 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 17:21:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c269424278be4ae555e8af3a00c80ac59c3a33e
Cr-Commit-Position: refs/heads/master@{#29764}

Powered by Google App Engine
This is Rietveld 408576698